kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Removing unused matches? method

Browse source 
@lifo I couldn’t find any use of documentation for this, so removed it
for now. Was it just for testing?
This commit is contained in:
David Heinemeier Hansson 2015-07-06 19:35:41 +02:00
parent 70361c7ddf
commit e6effb247a
3 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/action_cable/channel/base.rb
View file

@ -11,12 +11,6 @@ module ActionCable
attr_reader :params, :connection
delegate :logger, to: :connection
class << self
def matches?(identifier)
raise "Please implement #{name}#matches? method"
end
end
def initialize(connection, channel_identifier, params = {})
@connection = connection
@channel_identifier = channel_identifier

3
test/channel_test.rb
View file

@ -3,9 +3,6 @@ require 'test_helper'
class ChannelTest < ActionCableTest
class PingChannel < ActionCable::Channel::Base
def self.matches?(identifier)
identifier[:channel] == 'chat' && identifier[:user_id].to_i.nonzero?
end
end
class PingServer < ActionCable::Server::Base

3
test/server_test.rb
View file

@ -3,9 +3,6 @@ require 'test_helper'
class ServerTest < ActionCableTest
class ChatChannel < ActionCable::Channel::Base
def self.matches?(identifier)
identifier[:channel] == 'chat' && identifier[:user_id].to_i.nonzero?
end
end
class ChatServer < ActionCable::Server::Base