kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Nobody sucks so nobody should call this awful method name

Browse source
This commit is contained in:
Rafael Mendonça França 2014-08-12 10:51:41 -03:00
parent 9424b48d39
commit e81f3c210e
9 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionmailer/test/abstract_unit.rb
View file

@ -55,4 +55,4 @@ require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
ActiveSupport::TestCase.my_tests_are_order_dependent!

2
actionpack/test/abstract_unit.rb
View file

@ -501,4 +501,4 @@ end
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
ActiveSupport::TestCase.my_tests_are_order_dependent!

2
actionview/test/abstract_unit.rb
View file

@ -344,4 +344,4 @@ require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
ActiveSupport::TestCase.my_tests_are_order_dependent!

2
activemodel/test/cases/helper.rb
View file

@ -17,4 +17,4 @@ require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
ActiveSupport::TestCase.my_tests_are_order_dependent!

2
activerecord/test/cases/helper.rb
View file

@ -205,4 +205,4 @@ require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
ActiveSupport::TestCase.tests_are_order_dependent!

2
activesupport/CHANGELOG.md
View file

@ -1,6 +1,6 @@
* Fix ActiveSupport::TestCase not to order users' test cases by default.
If this change breaks your tests because your tests are order dependent, you need to explicitly call
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! at the top of your tests.
ActiveSupport::TestCase.my_tests_are_order_dependent! at the top of your tests.
*Akira Matsuda*

4
activesupport/lib/active_support/test_case.rb
View file

@ -15,6 +15,10 @@ module ActiveSupport
class TestCase < ::Minitest::Test
Assertion = Minitest::Assertion
class << self
alias :my_tests_are_order_dependent! :i_suck_and_my_tests_are_order_dependent!
end
alias_method :method_name, :name
include ActiveSupport::Testing::TaggedLogging

2
activesupport/test/abstract_unit.rb
View file

@ -42,4 +42,4 @@ require 'mocha/setup' # FIXME: stop using mocha
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
require 'active_support/test_case'
ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent!
ActiveSupport::TestCase.my_tests_are_order_dependent!

2
railties/test/abstract_unit.rb
View file

@ -30,7 +30,7 @@ end
class ActiveSupport::TestCase
# FIXME: we have tests that depend on run order, we should fix that and
# remove this method call.
self.i_suck_and_my_tests_are_order_dependent!
self.my_tests_are_order_dependent!
private