kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #26589 from kirs/ad-test-request-method

Browse source 
Fix memoization bug on ActionDispatch::TestRequest#request_method=
This commit is contained in:
Arthur Nogueira Neves 2016-09-22 13:30:13 -04:00 committed by GitHub
commit f08bb28702
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/lib/action_dispatch/testing/test_request.rb
View file

@ -22,7 +22,7 @@ module ActionDispatch
private_class_method :default_env
def request_method=(method)
set_header("REQUEST_METHOD", method.to_s.upcase)
super(method.to_s.upcase)
end
def host=(host)

7
actionpack/test/dispatch/test_request_test.rb
View file

@ -88,6 +88,13 @@ class TestRequestTest < ActiveSupport::TestCase
assert_equal "GoogleBot", req.user_agent
end
test "request_method getter and setter" do
req = ActionDispatch::TestRequest.create
req.request_method # to reproduce bug caused by memoization
req.request_method = "POST"
assert_equal "POST", req.request_method
end
test "setter methods" do
req = ActionDispatch::TestRequest.create({})
get = "GET"