mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Use Colspan in th Tags
Is it more suitable that using ```<th colspan="3">``` instead of three empty ```<th>```? It is simple, but what i am missing about it? Change repetitive th tags to use colspan attribute Update CHANGELOG.md Update CHANGELOG.md
This commit is contained in:
parent
ce13dc28e4
commit
f0e4254bfa
4 changed files with 10 additions and 9 deletions
|
@ -1,3 +1,5 @@
|
|||
* No changes.
|
||||
* Removed repetitive th tags. Instead of them added one th tag with a colspan attribute.
|
||||
|
||||
*Sıtkı Bağdat*
|
||||
|
||||
Please check [4-0-stable](https://github.com/rails/rails/blob/4-0-stable/guides/CHANGELOG.md) for previous changes.
|
||||
|
|
|
@ -932,8 +932,7 @@ appear next to the "Show" link:
|
|||
<tr>
|
||||
<th>Title</th>
|
||||
<th>Text</th>
|
||||
<th></th>
|
||||
<th></th>
|
||||
<th colspan="2"></th>
|
||||
</tr>
|
||||
|
||||
<% @posts.each do |post| %>
|
||||
|
@ -1073,9 +1072,7 @@ together.
|
|||
<tr>
|
||||
<th>Title</th>
|
||||
<th>Text</th>
|
||||
<th></th>
|
||||
<th></th>
|
||||
<th></th>
|
||||
<th colspan="3"></th>
|
||||
</tr>
|
||||
|
||||
<% @posts.each do |post| %>
|
||||
|
|
|
@ -13,4 +13,8 @@
|
|||
|
||||
*John Wang*
|
||||
|
||||
* Changes repetitive th tags to use colspan attribute in `index.html.erb` template.
|
||||
|
||||
*Sıtkı Bağdat*
|
||||
|
||||
Please check [4-0-stable](https://github.com/rails/rails/blob/4-0-stable/railties/CHANGELOG.md) for previous changes.
|
||||
|
|
|
@ -6,9 +6,7 @@
|
|||
<% attributes.reject(&:password_digest?).each do |attribute| -%>
|
||||
<th><%= attribute.human_name %></th>
|
||||
<% end -%>
|
||||
<th></th>
|
||||
<th></th>
|
||||
<th></th>
|
||||
<th colspan="3"></th>
|
||||
</tr>
|
||||
</thead>
|
||||
|
||||
|
|
Loading…
Reference in a new issue