kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Pass multiple arguments to Element.show and Element.hide in JavaScriptGenerator instead of using iterators

Browse source 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3116 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
Sam Stephenson 2005-11-21 01:54:36 +00:00
parent a0293c80f0
commit f212c88315
3 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/CHANGELOG
View file

@ -1,5 +1,7 @@
*SVN*
* Pass multiple arguments to Element.show and Element.hide in JavaScriptGenerator instead of using iterators. [Sam Stephenson]
* Improve expire_fragment documentation. #2966 [court3nay@gmail.com]
* Correct docs for automatic layout assignment. #2610. [Charles M. Gerungan]

4
actionpack/lib/action_view/helpers/prototype_helper.rb
View file

@ -435,12 +435,12 @@ module ActionView
# Shows hidden DOM elements with the given +ids+.
def show(*ids)
record "#{ids.inspect}.each(Element.show)"
record "Element.show(#{ids.map {|id| id.inspect} * ', '})"
end
# Hides the visible DOM elements with the given +ids+.
def hide(*ids)
record "#{ids.inspect}.each(Element.hide)"
record "Element.hide(#{ids.map {|id| id.inspect} * ', '})"
end
private

8
actionpack/test/template/prototype_helper_test.rb
View file

@ -179,16 +179,16 @@ class JavaScriptGeneratorTest < Test::Unit::TestCase
end
def test_show
assert_equal '["foo"].each(Element.show);',
assert_equal 'Element.show("foo");',
@generator.show('foo')
assert_equal '["foo", "bar", "baz"].each(Element.show);',
assert_equal 'Element.show("foo", "bar", "baz");',
@generator.show('foo', 'bar', 'baz')
end
def test_hide
assert_equal '["foo"].each(Element.hide);',
assert_equal 'Element.hide("foo");',
@generator.hide('foo')
assert_equal '["foo", "bar", "baz"].each(Element.hide);',
assert_equal 'Element.hide("foo", "bar", "baz");',
@generator.hide('foo', 'bar', 'baz')
end