1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

clear the rest of the warnings, run with warnings turned on [#4332 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
This commit is contained in:
Aaron Patterson 2010-04-06 00:18:22 -07:00 committed by José Valim
parent 922e4c57a4
commit f46dc9b6b7
2 changed files with 40 additions and 25 deletions

View file

@ -50,6 +50,7 @@ end
t.libs << "test" << connection_path t.libs << "test" << connection_path
t.test_files=Dir.glob( "test/cases/**/*_test{,_#{adapter_short}}.rb" ).sort t.test_files=Dir.glob( "test/cases/**/*_test{,_#{adapter_short}}.rb" ).sort
t.verbose = true t.verbose = true
t.warning = true
} }
task "isolated_test_#{adapter}" do task "isolated_test_#{adapter}" do

View file

@ -1136,21 +1136,6 @@ if ActiveRecord::Base.connection.supports_migrations?
load(MIGRATIONS_ROOT + "/valid/1_people_have_last_names.rb") load(MIGRATIONS_ROOT + "/valid/1_people_have_last_names.rb")
end end
def test_migrator_interleaved_migrations
ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/interleaved/pass_1")
assert_nothing_raised do
ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/interleaved/pass_2")
end
Person.reset_column_information
assert Person.column_methods_hash.include?(:last_name)
assert_nothing_raised do
ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/interleaved/pass_3")
end
end
def test_migrator_db_has_no_schema_migrations_table def test_migrator_db_has_no_schema_migrations_table
# Oracle adapter raises error if semicolon is present as last character # Oracle adapter raises error if semicolon is present as last character
if current_adapter?(:OracleAdapter) if current_adapter?(:OracleAdapter)
@ -1362,16 +1347,6 @@ if ActiveRecord::Base.connection.supports_migrations?
end end
end end
def test_migration_should_be_run_without_logger
previous_logger = ActiveRecord::Base.logger
ActiveRecord::Base.logger = nil
assert_nothing_raised do
ActiveRecord::Migrator.migrate(MIGRATIONS_ROOT + "/valid")
end
ensure
ActiveRecord::Base.logger = previous_logger
end
protected protected
def with_env_tz(new_tz = 'US/Eastern') def with_env_tz(new_tz = 'US/Eastern')
old_tz, ENV['TZ'] = ENV['TZ'], new_tz old_tz, ENV['TZ'] = ENV['TZ'], new_tz
@ -1457,6 +1432,45 @@ if ActiveRecord::Base.connection.supports_migrations?
end # SexyMigrationsTest end # SexyMigrationsTest
class MigrationLoggerTest < ActiveRecord::TestCase
def setup
Object.send(:remove_const, :InnocentJointable)
end
def test_migration_should_be_run_without_logger
previous_logger = ActiveRecord::Base.logger
ActiveRecord::Base.logger = nil
assert_nothing_raised do
ActiveRecord::Migrator.migrate(MIGRATIONS_ROOT + "/valid")
end
ensure
ActiveRecord::Base.logger = previous_logger
end
end
class InterleavedMigrationsTest < ActiveRecord::TestCase
def setup
Object.send(:remove_const, :PeopleHaveLastNames)
end
def test_migrator_interleaved_migrations
ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/interleaved/pass_1")
assert_nothing_raised do
ActiveRecord::Migrator.up(MIGRATIONS_ROOT + "/interleaved/pass_2")
end
Person.reset_column_information
assert Person.column_methods_hash.include?(:last_name)
Object.send(:remove_const, :PeopleHaveLastNames)
Object.send(:remove_const, :InnocentJointable)
assert_nothing_raised do
ActiveRecord::Migrator.down(MIGRATIONS_ROOT + "/interleaved/pass_3")
end
end
end
class ChangeTableMigrationsTest < ActiveRecord::TestCase class ChangeTableMigrationsTest < ActiveRecord::TestCase
def setup def setup
@connection = Person.connection @connection = Person.connection