Do not eager load ActiveRecord::Base

Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.

activestorage/app/controllers/active_storage/variants_controller.rb

@@ -1,5 +1,3 @@
-require "active_storage/variant"
-
 # Take a signed permanent reference for a variant and turn it into an expiring service URL for download.
 # Note: These URLs are publicly accessible. If you need to enforce access protection beyond the
 # security-through-obscurity factor of the signed blob and variation reference, you'll need to implement your own

activestorage/app/models/active_storage/attachment.rb

@@ -1,4 +1,3 @@
-require "active_storage/blob"
 require "active_support/core_ext/module/delegation"
 
 # Attachments associate records with blobs. Usually that's a one record-many blobs relationship, 

activestorage/app/models/active_storage/blob.rb

@@ -1,9 +1,3 @@
-require "active_storage/service"
-require "active_storage/filename"
-require "active_storage/purge_job"
-require "active_storage/variant"
-require "active_storage/variation"
-
 # A blob is a record that contains the metadata about a file and a key for where that file resides on the service.
 # Blobs can be created in two ways:
 #

activestorage/lib/active_storage/attached.rb

@@ -1,6 +1,3 @@
-require "active_storage/blob"
-require "active_storage/attachment"
-
 require "action_dispatch/http/upload"
 require "active_support/core_ext/module/delegation"
 

railties/test/application/initializers/frameworks_test.rb

@@ -233,11 +233,9 @@ module ApplicationTests
 
     test "active record establish_connection uses Rails.env if DATABASE_URL is not set" do
       begin
-        orig_database_url = ENV.delete("DATABASE_URL")
-
         require "#{app_path}/config/environment"
+        orig_database_url = ENV.delete("DATABASE_URL")
         orig_rails_env, Rails.env = Rails.env, "development"
-
         ActiveRecord::Base.establish_connection
         assert ActiveRecord::Base.connection
         assert_match(/#{ActiveRecord::Base.configurations[Rails.env]['database']}/, ActiveRecord::Base.connection_config[:database])
@@ -250,13 +248,11 @@ module ApplicationTests
 
     test "active record establish_connection uses DATABASE_URL even if Rails.env is set" do
       begin
+        require "#{app_path}/config/environment"
         orig_database_url = ENV.delete("DATABASE_URL")
+        orig_rails_env, Rails.env = Rails.env, "development"
         database_url_db_name = "db/database_url_db.sqlite3"
         ENV["DATABASE_URL"] = "sqlite3:#{database_url_db_name}"
-
-        require "#{app_path}/config/environment"
-        orig_rails_env, Rails.env = Rails.env, "development"
-
         ActiveRecord::Base.establish_connection
         assert ActiveRecord::Base.connection
         assert_match(/#{database_url_db_name}/, ActiveRecord::Base.connection_config[:database])

railties/test/application/rake/dbs_test.rb

@@ -42,8 +42,8 @@ module ApplicationTests
       end
 
       test "db:create and db:drop with database url" do
-        set_database_url
         require "#{app_path}/config/environment"
+        set_database_url
         db_create_and_drop database_url_db_name
       end
 
@@ -154,8 +154,8 @@ module ApplicationTests
       end
 
       test "db:fixtures:load with database_url" do
-        set_database_url
         require "#{app_path}/config/environment"
+        set_database_url
         db_fixtures_load database_url_db_name
       end
 
@@ -189,8 +189,8 @@ module ApplicationTests
       end
 
       test "db:structure:dump and db:structure:load with database_url" do
-        set_database_url
         require "#{app_path}/config/environment"
+        set_database_url
         db_structure_dump_and_load database_url_db_name
       end