Consistently use visitor.compile

activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb

@@ -20,7 +20,7 @@ module ActiveRecord
             raise "Passing bind parameters with an arel AST is forbidden. " \
               "The values must be stored on the AST directly"
           end
-          sql, binds = visitor.accept(arel_or_sql_string.ast, collector).value
+          sql, binds = visitor.compile(arel_or_sql_string.ast, collector)
           [sql.freeze, binds || []]
         else
           [arel_or_sql_string.dup.freeze, binds]
@@ -32,11 +32,11 @@ module ActiveRecord
       # can be used to query the database repeatedly.
       def cacheable_query(klass, arel) # :nodoc:
         if prepared_statements
-          sql, binds = visitor.accept(arel.ast, collector).value
+          sql, binds = visitor.compile(arel.ast, collector)
           query = klass.query(sql)
         else
           collector = PartialQueryCollector.new
-          parts, binds = visitor.accept(arel.ast, collector).value
+          parts, binds = visitor.compile(arel.ast, collector)
           query = klass.partial_query(parts)
         end
         [query, binds]

activerecord/lib/arel/visitors/to_sql.rb

@@ -67,8 +67,8 @@ module Arel # :nodoc: all
         @connection = connection
       end
 
-      def compile(node, &block)
+      def compile(node, collector = Arel::Collectors::SQLString.new, &block)
-        accept(node, Arel::Collectors::SQLString.new, &block).value
+        accept(node, collector, &block).value
       end
 
       private