kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix observe_field to fall back to event-based observation if frequency <= 0 #1916 [michael@schubert.cx]

Browse source 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
Jamis Buck 2005-09-02 14:06:17 +00:00
parent 97adfdaa65
commit fd9c15e420
2 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/CHANGELOG
View file

@ -1,5 +1,7 @@
*SVN*
* Fix observe_field to fall back to event-based observation if frequency <= 0 #1916 [michael@schubert.cx]
* Allow use of the :with option for submit_to_remote #1936 [jon@instance-design.co.uk]
* AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com]

9
actionpack/lib/action_view/helpers/javascript_helper.rb
View file

@ -305,9 +305,10 @@ module ActionView
#
# Additional options are:
# <tt>:frequency</tt>:: The frequency (in seconds) at which changes to
# this field will be detected. Set this to a value
# greater than zero to use time based observation
# instead of event based observation.
# this field will be detected. Not setting this
# option at all or to a value equal to or less than
# zero will use event based observation instead of
# time based observation.
# <tt>:update</tt>:: Specifies the DOM ID of the element whose
# innerHTML should be updated with the
# XMLHttpRequest response text.
@ -319,7 +320,7 @@ module ActionView
# Additionally, you may specify any of the options documented in
# +link_to_remote.
def observe_field(field_id, options = {})
if options[:frequency]
if options[:frequency] and options[:frequency] > 0
build_observer('Form.Element.Observer', field_id, options)
else
build_observer('Form.Element.EventObserver', field_id, options)