kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222

Browse source 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
David Heinemeier Hansson 2005-04-30 08:19:14 +00:00
parent 8694a79bb2
commit fe00c275cd
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/CHANGELOG
View file

@ -1,5 +1,7 @@
*SVN*
* Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222
* Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log. Example:
<% benchmark "Notes section" do %>

7
actionpack/lib/action_controller/templates/rescues/_request_and_response.rhtml
View file

@ -33,10 +33,6 @@
request_dump = request_parameters_without_action.inspect.gsub(/,/, ",\n")
session_dump = @request.session.instance_variable_get("@data").inspect.gsub(/,/, ",\n")
response_dump = @response.inspect.gsub(/,/, ",\n")
template_assigns = @response.template.instance_variable_get("@assigns")
%w( response exception template session request template_root template_class url ignore_missing_templates logger cookies headers params ).each { |t| template_assigns.delete(t) }
template_dump = template_assigns.inspect.gsub(/,/, ",\n")
%>
<h2 style="margin-top: 30px">Request</h2>
@ -48,6 +44,3 @@
<h2 style="margin-top: 30px">Response</h2>
<b>Headers</b>: <%=h @response.headers.inspect.gsub(/,/, ",\n") %><br/>
<p><a href="#" onclick="document.getElementById('template_dump').style.display='block'; return false;">Show template parameters</a></p>
<div id="template_dump" style="display:none"><%= debug(template_assigns) %></div>