Revert "Merge pull request #20584 from arthurnn/fix_url"

This reverts commit 0b33978725, reversing
changes made to 56d52e3749.

As pointed out on the PR, this will hide development mistakes too, which
is not ideal.

actionpack/CHANGELOG.md

@@ -1,7 +1,3 @@
-*   Handle InvalidURIError on bad paths on redirect route.
-
-    *arthurnn*
-
 *   Deprecate passing first parameter as `Hash` and default status code for `head` method.
 
     *Mehmet Emin İNAÇ*

actionpack/lib/action_dispatch/routing/redirection.rb

@@ -23,12 +23,8 @@ module ActionDispatch
 
       def serve(req)
         req.check_path_parameters!
-        begin
-          uri = URI.parse(path(req.path_parameters, req))
-        rescue URI::InvalidURIError
-          return [ 400, {}, ['Invalid path.'] ]
-        end
-
+        uri = URI.parse(path(req.path_parameters, req))
+        
         unless uri.host
           if relative_path?(uri.path)
             uri.path = "#{req.script_name}/#{uri.path}"
@@ -36,7 +32,7 @@ module ActionDispatch
             uri.path = req.script_name.empty? ? "/" : req.script_name
           end
         end
-
+          
         uri.scheme ||= req.scheme
         uri.host   ||= req.host
         uri.port   ||= req.port unless req.standard_port?
@@ -128,7 +124,7 @@ module ActionDispatch
             url_options[:script_name] = request.script_name
           end
         end
-
+        
         ActionDispatch::Http::URL.url_for url_options
       end
 

actionpack/test/journey/router_test.rb

@@ -219,13 +219,6 @@ module ActionDispatch
         assert_equal 404, resp.first
       end
 
-      def test_invalid_url_path
-        routes = Class.new { include ActionDispatch::Routing::Redirection }.new
-        route = routes.redirect("/foo/bar/%{id}")
-        resp = route.serve(rails_env({ 'REQUEST_METHOD' => 'GET', 'PATH_INFO' => '/foo/(function(){})' }))
-        assert_equal 400, resp.first
-      end
-
       def test_clear_trailing_slash_from_script_name_on_root_unanchored_routes
         route_set = Routing::RouteSet.new
         mapper = Routing::Mapper.new route_set