1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

25 commits

Author SHA1 Message Date
Alberto Almagro
558ccf4a21 Privatize constants
This constants meant to be private but `private_constant` was missing,
this commit makes them fully private by adding  `private_constant`.
2018-10-11 14:39:08 +02:00
Alberto Almagro
34f2e9492b Add frozen_string_literal: true
Adds frozen_string_literal: true comment on top of all currently existing files
2018-10-08 23:44:25 +02:00
ven
03647a3b74
Fix minor typo in code comment 2018-10-06 16:51:39 +02:00
Jason Lee
33f940f140 Fix has_rich_text with :body keywords error. (#16) 2018-10-05 20:47:10 -07:00
Javan Makhmali
d43d7f1970 Delegate string methods to content
Closes #11
2018-10-04 08:00:38 -04:00
George Claghorn
1a4a582ddc Install Active Storage extension lazily
Avoid eagerly loading Active Record during app boot. Reinstall the extension when ActiveStorage::Blob is reloaded in dev.
2018-10-03 22:26:15 -04:00
Javan Makhmali
3044312128 Move attachment rendering to a helper
Fixes #5
2018-10-03 14:41:47 -04:00
Javan Makhmali
7a99332434 WIP: Image gallery support 2018-10-03 12:46:05 -04:00
Javan Makhmali
2bd0f608f2 Add support for "presentation" gallery attribute 2018-10-03 12:11:39 -04:00
Javan Makhmali
e5cc70ea17 Fill in Attachable rich text attributes 2018-10-03 12:10:09 -04:00
Javan Makhmali
7bbddb0173 Fix <h1> plain text conversion
Fixes #4
2018-10-02 13:57:50 -04:00
Javan Makhmali
a37b90881d active → action 2018-10-02 13:32:06 -04:00
David Heinemeier Hansson
531d7dd584 Never mind on allowing blank
More hassle than its worth. Just account for the fact that rich text can be blank instead, but continue to create the record.
2018-09-12 15:51:06 -07:00
David Heinemeier Hansson
3431c0b3ee Ensure blank rich text records aren't saved or required 2018-09-12 10:58:23 -07:00
David Heinemeier Hansson
2f530577ce #render already provides something html_safe 2018-06-07 14:41:57 +02:00
David Heinemeier Hansson
206c04f716 Move the escaping choice to the layout 2018-06-07 14:41:17 +02:00
David Heinemeier Hansson
228044c5c2 Some basic documentation for the has_rich_text macro 2018-06-07 14:39:09 +02:00
David Heinemeier Hansson
83d781ed01 Add scope to preload embeds as well 2018-06-07 14:38:57 +02:00
David Heinemeier Hansson
d5623dc634 Provide to_html rendering within a layout and use that as the to_s default
I like the idea of thinking about the rendering as happening within a
layout. Since that’s basically what this wrapper is. Thoughts @javan?
2018-06-07 14:38:41 +02:00
David Heinemeier Hansson
9e5ab1ebd9 By default, coercing to a string should produce a formatted output
Open to other ways of doing this, but didn’t want to require embedding
the trix-content class inside the actual HTML that Trix persists. So
this seemed like a reasonable alternative. Thoughts @javan or
@sstephenson?
2018-06-05 16:37:50 +02:00
David Heinemeier Hansson
a79fa9d223 Destroy rich text dependents 2018-05-29 16:12:28 +02:00
David Heinemeier Hansson
e63acf4513 Auto-save changes to rich text model 2018-05-28 17:43:21 +02:00
David Heinemeier Hansson
94a95db2f5 Lazy initialization of rich text model 2018-05-28 17:43:08 +02:00
David Heinemeier Hansson
7daa8cc63e WIP 2018-04-13 16:47:33 -07:00
David Heinemeier Hansson
f1d74871e7 Rename from Active Text to Action Text
This is more like Action View than Active Model.
2018-04-13 16:23:04 -07:00