Rafael Mendonça França
82667c84e1
Remove warning renaming the test classes to use the test convention
2012-07-29 17:47:05 -03:00
Jose and Yehuda
56cdc81c08
Remove default match without specified method
...
In the current router DSL, using the +match+ DSL
method will match all verbs for the path to the
specified endpoint.
In the vast majority of cases, people are
currently using +match+ when they actually mean
+get+. This introduces security implications.
This commit disallows calling +match+ without
an HTTP verb constraint by default. To explicitly
match all verbs, this commit also adds a
:via => :all option to +match+.
Closes #5964
2012-04-24 22:52:26 -05:00
Santiago Pastorino
500c9a161c
Revert "Merge pull request #5750 from ahoward/master"
...
This reverts commit 174cf8b220
, reversing
changes made to 7ecd6a731b
.
The reverted commit improved the performance in the wrong place, now we
have added this 6ddbd1844a
improvement.
2012-04-08 22:44:37 -03:00
Rafael Mendonça França
ddbd1e4adb
Make url_for work when option is nil and default_url_options has
...
stringified keys
2012-04-05 15:14:00 -03:00
ara.t.howard
697991a201
carefully and quickly merge url_for options
2012-04-04 16:28:19 -06:00
Aaron Suggs
0c525f68f2
Add test for default_url_options[:port]
2012-03-28 13:31:37 +02:00
choonkeat
5f67cfeda1
Fix url_for options[:subdomain] to allow objects as values
...
* e.g. blog_url(subdomain: current_user) instead of blog_url(subdomain: current_user.to_param)
2011-12-14 22:43:42 +08:00
Bradford Folkens
bd559b0068
Fix trouble using :subdomain in development environment when using numeric addresses.
...
See-also pull request #3561 from 3-1-stable
Otherwise the following occurs:
TypeError: can't convert nil into String
/Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:75:in host_or_subdomain_and_domain'
/Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:37:in url_for'
/Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/routing/url_for.rb:147:in test_subdomain_may_be_accepted_with_numeric_host'
/Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in run'
/Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:426:in send'
/Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:81:in run'
2011-11-08 07:52:35 -06:00
Kamil Sobieraj
de942e5534
:subdomain can now be specified with a value of false in url_for, allowing for subdomain(s) removal from the host during link generation. Closes #2025
2011-10-04 09:16:34 +01:00
Neeraj Singh
6688b6393a
expected message should come first
2011-06-11 03:11:06 -04:00
Andrew White
03cbd9672c
Filter params that return nil for to_param and allow through false values
2011-03-09 14:44:25 +00:00
Stephen Celis
a0757e00f3
Protocol-relative URL support.
...
[#5774 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-02-02 19:09:44 -02:00
Josh Kalderimis
2fe43b694f
:subdomain, :domain and :tld_length options can now be used in url_for, allowing for easy manipulation of the host during link generation.
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-11-23 09:54:42 +01:00
Emilio Tagua
2d274a5208
Use parentheses when using assert_match followed by a regexp to avoid warnings.
2010-09-27 11:19:19 -03:00
Łukasz Strzałkowski
8659c5e657
Fixed url_for test
...
Added route which matches all: controller, action, id and format
2010-09-05 13:44:36 +02:00
Piotr Sarnacki
b3eb26a161
Removed deprecated RouteSet API, still many tests fail
2010-09-05 13:44:36 +02:00
Piotr Sarnacki
f7ba614c2d
Unify routes naming by renaming router to routes
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-07-02 01:51:03 +02:00
Andrew White
bba19603c2
URL fragments should not have safe characters escaped. Ref: Appendix A, http://tools.ietf.org/rfc/rfc3986.txt
...
[#4762 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-06-25 18:05:40 -07:00
Santiago Pastorino
920df0a475
Make ActionDispatch url_for use HWIA symbolize_keys
...
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-04-22 09:06:55 -07:00
J Smith
275e839b8d
Ensure that url_for uses symbolized keys in the controller. [ #4391 ]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-04-22 16:47:36 +02:00
Carlhuda
900a2d304a
Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request.
2010-03-04 17:43:46 -08:00
Carlhuda
bcfb77782b
Work on deprecating ActionController::Base.relative_url_root
2010-03-03 15:49:52 -08:00
Carlhuda
ab0cc7286f
Setting UrlFor in with_routing is no longer needed now that it's not global
2010-02-26 15:56:38 -08:00
Carlhuda
226dfc2681
WIP: Remove the global router
2010-02-25 17:53:00 -08:00
José Valim
3f84091937
ActionMailer should depend just on AbstractController.
2010-01-29 17:51:05 +01:00