Commit Graph

9 Commits

Author SHA1 Message Date
Ryuta Kamizono 1745e905a3 Allow changing text and blob size without giving the `limit` option
In MySQL, the text column size is 65,535 bytes by default (1 GiB in
PostgreSQL). It is sometimes too short when people want to use a text
column, so they sometimes change the text size to mediumtext (16 MiB) or
longtext (4 GiB) by giving the `limit` option.

Unlike MySQL, PostgreSQL doesn't allow the `limit` option for a text
column (raises ERROR: type modifier is not allowed for type "text").
So `limit: 4294967295` (longtext) couldn't be used in Action Text.

I've allowed changing text and blob size without giving the `limit`
option, it prevents that migration failure on PostgreSQL.
2019-01-29 06:49:32 +09:00
Ryuta Kamizono b8baa15adb Revert "Apply `t.timestamps` changes in Action Text and Action Mailbox"
This reverts commit 30f666f87a.
2019-01-29 06:37:42 +09:00
Ryuta Kamizono 30f666f87a Apply `t.timestamps` changes in Action Text and Action Mailbox
Follow up #34956.
2019-01-29 04:59:36 +09:00
Ryuta Kamizono db077e8090 Allow using Action Mailbox on MySQL 5.5
Active Record still support MySQL 5.5 which doesn't support datetime
with precision.

9e34df0003/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb (L99-L101)

So we should check `supports_datetime_with_precision?` on the
connection.
2019-01-18 07:04:08 +09:00
Pratik Naik a823b7d56f Specify a name for [ message_id, message_checksum ] index to ensure the name does not exceed the limit.
Also, update test schema to reflect the recent changes.
2019-01-17 14:14:45 -06:00
Pratik Naik 5cd733a334 Ensure Action Mailbox processes an email only once when received multiple times
This also adds a new column, message_checksum, to the action_mailbox_inbound_emails table
for storing SHA1 digest of the email source. Additionally, it makes generating the missing
message id deterministic and adds a unique index on message_checksum and message_id to
detect duplicate emails.
2019-01-17 11:13:40 -06:00
ikepon 6c156d4f6e Add 'null: false' to Action Mailbox table
created_at and updated_at columns in Action Mailbox table aren't intended nullable.
2019-01-16 15:40:15 +09:00
bogdanvlviv f9792fdd51
Use 6.0 version of ActiveRecord::Migration for Action Mailbox
Since Action Mailbox will be introduced in Rails 6.0,
it makes more sense to generate migration of that version.
Also I changed its test dummy app to use default 6.0 configs.
2018-12-30 03:10:16 +02:00
George Claghorn a5b2fff64c Import Action Mailbox 2018-12-25 21:32:35 -05:00