1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

19 commits

Author SHA1 Message Date
Brian Cardarella
748d3f38df Use symbols instead of strings
ActiveSupport::Concern is used all over Rails
This PR will only create 3 new objects as keys are never recreated and
are not subject to garbage collection.

The strings were being uniquely created and garbage collected. I don't
have any performance numbers but this should be better than all of the
GC.
2013-06-10 23:22:08 -04:00
Mike Dillon
2d7a86e179 Raise when multiple included blocks are defined 2013-05-16 11:28:31 -07:00
maximerety
2ff888181d Fix another AS::Concern example (class_eval is already called by included) 2012-11-15 19:18:04 +01:00
maximerety
d0ba816fcf Fix AS::Concern example (current example doesn't work) 2012-11-15 19:18:04 +01:00
José Corcuera
66bc017849 Update examples in AS::Concern to use correct scope syntax. [ci skip] 2012-09-21 12:29:44 -05:00
Francesco Rodriguez
d71d5ba71f update AS docs [ci skip] 2012-09-17 00:22:18 -05:00
Francesco Rodriguez
bc7ac33846 add :nodoc: to internal implementations [ci skip] 2012-06-22 16:29:59 -05:00
José Valim
6a6fc4e1db Remove deprecations from Active Support. 2011-12-20 15:18:42 +01:00
José Valim
401393b656 Deprecate InstanceMethods namespace handling in ActiveSupport::Concern.
This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions.
2011-11-21 22:17:35 +00:00
zhengjia
ad14926b44 Fix the example in ActiveSupport::Concern 2010-12-17 18:54:57 -06:00
Xavier Noria
21bbcfe42c reviews commit dcc9d38 2010-08-15 02:22:37 +02:00
Josep M. Bach
ca87d0a395 Documentation just before Concern module 2010-08-15 02:22:37 +02:00
Josep M. Bach
98818f92b8 Documented active_support/concern dependency handling 2010-08-15 02:22:37 +02:00
Tom Stuart
f544c0a32d Fix ActiveSupport::Callbacks' define_callbacks and ActiveSupport::Concern documentation to look like native English 2010-08-05 09:06:47 +01:00
Neeraj Singh
589e6977d7 adding documentation to ActiveSupport::Concern ht:strictly typed for an awesome example
some minor documentation changes
2010-08-04 17:03:03 -04:00
Joshua Peek
7ec947d59c Refactor AS concern to avoid hacking the "include" method.
Ruby Magic!
2009-10-13 23:32:32 -05:00
Joshua Peek
669fd84910 AS::Concern redefines "include" to lazy include modules as dependencies 2009-05-29 17:03:23 -05:00
Joshua Peek
c7c35be8fe AS::Concern includes InstanceMethods module if it exists 2009-05-29 16:28:54 -05:00
Joshua Peek
4e50a35fa2 Break up DependencyModule's dual function of providing a "depend_on" DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern. 2009-05-28 11:35:36 -05:00