13b1d9dc35
chore: fix grammar and spelling
2021-04-12 05:30:44 +10:00
d98d749222
Revert "Merge pull request #39304 from zenspider/zenspider/backtrace_filter_should_never_return_empty"
...
This reverts commit 2eb7aa111b0b28f0c39c345de17caf/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb (L72)
2020-10-06 22:31:41 +00:00
5611f4b430
Anchor BacktraceCleaner gem filter regexp
...
This ensures the default gem filter does not affect backtrace lines that
have a subpath incidentally matching a gem path.
Fixes #40196 .
2020-09-07 16:44:57 -05:00
3116bdceba
Fixed BacktraceCleaner to never return an empty backtrace.
...
Empty backtraces means you didn't run any code, which isn't the case,
and goes against the contract that Minitest.backtrace_cleaner expects.
This fixes a bug I've seen in a number of reports.
It would be nice if this got backported to whatever versions are
active, as this keeps coming back on minitest issues.
2020-05-15 16:42:27 -07:00
203998c916
allow running each test with pure ruby path/to/test.rb
...
also:
- makes test dependencies obvious
- makes tests runnable from within subfolders
2019-12-18 08:49:19 -06:00
c675783eb4
Use backtrace cleaner to clean up backtrace for verbose query logs
2018-08-14 09:15:28 +10:00
4183d5dfa1
Enable `Layout/FirstParameterIndentation` cop
...
We have some indentation cops. But now there is a little inconsistent
params indentations. Enable `Layout/FirstParameterIndentation` cop to
prevent newly inconsistent indentation added and auto-correct to
existing violations.
2017-07-17 14:08:32 +09:00
ac717d65a3
[Active Support] `rubocop -a --only Layout/EmptyLineAfterMagicComment`
2017-07-11 13:12:32 +09:00
72950568dd
Use frozen-string-literal in ActiveSupport
2017-07-09 15:08:29 +03:00
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
b326e82dc0
applies remaining conventions across the project
2016-08-06 20:20:22 +02:00
a731125f12
applies new string literal convention in activesupport/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:10:53 +02:00
cfc91c31aa
systematic revision of =~ usage in AS
...
Where appropriate prefer the more concise Regexp#match?, String#include?,
String#start_with?, and String#end_with?
2016-07-22 23:13:49 +02:00
3b9cc0a56f
missing activesupport test coverage
2014-07-19 17:15:40 -07:00
a3678e45ec
Fix BacktraceCleaner#noise for multiple silencers.
...
The previous implementation of BacktraceSilencer#noise did not
work correctly if more than one silencer was configured --
specifically, it would only return noise which was matched by all
silencers.
The new implementation is such that anything that has been matched by
silencers is removed from the backtrace using Array#- (array
difference), ie. we now return all elements within a backtrace that
have been matched by any silencer (and are thus removed by #silence).
Fixes #11030 .
2013-06-20 19:54:32 +01:00
db03f13255
Remove extra test case.
...
Make the test description better reflect what is happening
2012-06-19 11:56:16 -06:00
b451de0d6d
Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;)
2010-08-14 04:12:33 -03:00
dc97430630
ActiveSupport::BacktraceCleaner#remove_filters! allows for completely untouched backtrace [ #4079 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-04-10 14:06:10 +02:00
f42c77f927
Added ActiveSupport::BacktraceCleaner and Rails::BacktraceCleaner for cutting down on backtrace noise (inspired by the Thoughtbot Quiet Backtrace plugin) [DHH]
2008-11-22 18:06:08 +01:00
John Bampton