14 commits

Author	SHA1	Message	Date
Kazuhiro NISHIYAMA	7f89d4e8bf	Use File::NULL instead of "/dev/null"	2017-07-31 21:58:42 +09:00
Kir Shatrov	dfcc766163	Use frozen string literal in actionpack/	2017-07-29 14:02:40 +03:00
Matthew Draper	87b3e226d6	Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" ... This reverts commit 3420a14590, reversing changes made to afb66a5a59.	2017-07-02 02:15:17 +09:30
Kir Shatrov	cfade1ec7e	Enforce frozen string in Rubocop	2017-07-01 02:11:03 +03:00
eileencodes	845aabbcd3	Remove unused simulate method ... This method was only used in the Rails tests and not by other methods in the Rails simulator. Because it's a no-doc'd class it should be safe to remove without deprecation.	2017-05-22 13:09:57 -04:00
Rafael Mendonça França	fe1f4b2ad5	Add more rubocop rules about whitespaces	2016-10-29 01:17:49 -02:00
Rafael Mendonça França	55f9b8129a	Add three new rubocop rules ... Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.	2016-08-16 04:30:11 -03:00
Xavier Noria	b326e82dc0	applies remaining conventions across the project	2016-08-06 20:20:22 +02:00
Xavier Noria	80e66cc4d9	normalizes indentation and whitespace across the project	2016-08-06 20:16:27 +02:00
Xavier Noria	35b3de8021	applies new string literal convention in actionpack/test ... The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.	2016-08-06 18:54:50 +02:00
Godfrey Chan	ff1192fea4	Eliminate JSON.{parse,load,generate,dump} and def to_json ... JSON.{dump,generate} offered by the JSON gem is not compatiable with Rails at the moment and can cause a lot of subtle bugs when passed certain data structures. This changed all direct usage of the JSON gem in internal Rails code to always go through AS::JSON.{decode,encode}. We also shouldn't be implementing `to_json` most of the time, and these occurances are replaced with an equivilent `as_json` implementation to avoid problems down the road. See [1] for all the juicy details. [1]: intridea/multi_json#138 (comment)	2013-11-05 22:26:45 -08:00
Rafael Mendonça França	dc8091b88f	Use ActiveSupport::TestCase in the journey tests	2012-12-31 14:40:43 -03:00
Rafael Mendonça França	5294ad82c6	Alias refute methods to assert_not and perfer assert_not on tests	2012-12-31 13:58:52 -03:00
Andrew White	56fee39c39	Integrate Journey into Action Dispatch ... Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49.	2012-12-19 22:13:08 +00:00