1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

21 commits

Author SHA1 Message Date
David Heinemeier Hansson
43bd726442 Stick with match concept 2018-09-20 17:27:41 -07:00
David Heinemeier Hansson
3fc8e5325f Style 2018-09-20 17:27:16 -07:00
David Heinemeier Hansson
d14f54b0e0 Expand router with real routing object and 4-way address options 2018-09-20 17:16:19 -07:00
David Heinemeier Hansson
2d6c79413d Use proper default 2018-09-20 16:32:03 -07:00
David Heinemeier Hansson
35654cdbd8 Less fancy 2018-09-19 17:13:57 -07:00
David Heinemeier Hansson
a166c21a49 Allow inbound emails to be created on the fly 2018-09-19 17:08:35 -07:00
David Heinemeier Hansson
8cd299286e before_processing should run before the inbound email has been marked as processing 2018-09-19 16:56:07 -07:00
David Heinemeier Hansson
c382d9b180 Extract method to encapsulate status tracking on inbound email 2018-09-19 16:54:49 -07:00
David Heinemeier Hansson
67ba89a8c7 Ensure raw email is created first
Otherwise jobs hanging off the InboundEmail won't be able to access the Active Storage data (as it won't have been uploaded yet).
2018-09-19 16:21:53 -07:00
David Heinemeier Hansson
da697e8444 Attach a concrete router to the root mailbox and use it
Don't think this is how it's going to stay. Doesn't feel like the right place for it.
2018-09-19 15:52:16 -07:00
David Heinemeier Hansson
ee6d9545dd Included in test helper now 2018-09-19 15:33:53 -07:00
David Heinemeier Hansson
26bfd1c59c Only deliver pending emails to the mailroom
Makes it easier to test without triggering this behavior.
2018-09-18 17:28:35 -07:00
David Heinemeier Hansson
029c693f19 Make a note for tying inbound email to exception
Then InboundEmail doesn't need to serialize or track the exception that went with it. The arrow will point the other way.
2018-09-18 17:13:49 -07:00
David Heinemeier Hansson
0f140fe158 Add callbacks 2018-09-18 16:42:38 -07:00
David Heinemeier Hansson
1ac1459b0f More scalable name!
There'll probably be other concerns we need to do around the processing.
2018-09-18 16:31:16 -07:00
David Heinemeier Hansson
016ba4dbfa Process inbound emails with state and exceptions 2018-09-18 16:26:30 -07:00
David Heinemeier Hansson
4a9b45ce22 Use a test helper to create fixtures rather than rely on them being predefined
Too much hassle to manage all the steps compared to just pointing to an .eml fixture and having it setup for you.
2018-09-18 16:07:06 -07:00
David Heinemeier Hansson
a6146d2e89 First end-to-end rickety test 2018-09-17 22:15:27 -07:00
David Heinemeier Hansson
061d77f7ca WIP: Router 2018-09-17 17:49:47 -07:00
David Heinemeier Hansson
6600155aee Base -> Mailbox
Won't need Base and can separate routing from execution 👍
2018-09-17 17:01:52 -07:00
David Heinemeier Hansson
82ff0c235b Action Mailbox -> Action Mailroom 2018-09-17 16:56:55 -07:00