Ryuta Kamizono
c81af6ae72
Enable Layout/EmptyLinesAroundAccessModifier cop
...
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776 ,
https://github.com/rails/rails/pull/34832#discussion_r244847195 ).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059 ).
That cop and enforced style will reduce the our code review cost.
2019-06-13 12:00:45 +09:00
Daniel Colson
94333a4c31
Use assert_predicate and assert_not_predicate
2018-01-25 23:32:59 -05:00
Kir Shatrov
dfcc766163
Use frozen string literal in actionpack/
2017-07-29 14:02:40 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Xavier Noria
80e66cc4d9
normalizes indentation and whitespace across the project
2016-08-06 20:16:27 +02:00
Xavier Noria
35b3de8021
applies new string literal convention in actionpack/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:54:50 +02:00
Prem Sichanugrist
8cb8ce98d9
Stop using deprecated render :text in test
...
This will silence deprecation warnings.
Most of the test can be changed from `render :text` to render `:plain`
or `render :body` right away. However, there are some tests that needed
to be fixed by hand as they actually assert the default Content-Type
returned from `render :body`.
2015-07-17 22:27:33 -04:00
Jorge Bejar
08cfe34174
Rename test methods in api conditional get controller tests
2015-06-11 16:54:14 -03:00
Santiago Pastorino
4c1b437ed7
Use nex hash syntax on tests
2015-06-11 16:54:13 -03:00
Santiago Pastorino
032778eefb
Add ActionController API functionality
2015-06-11 16:54:09 -03:00
