Cameron Cundiff
9a74c7b99b
Do not generate default alt text in image tags
...
- Auto-generating content from the filename of an image is not suitable
alternative text; alt text that isn't fully considered can be
distracting and fatiguing for screen readers users (blind, low vision,
dyslexic people).
- Setting a filename fallback short circuits screen reader default
behavior and configuration for blank descriptions.
- Setting poor defaults also creates false negatives for accessibility
linting and testing software, that makes it harder to improve
application accessibility.
***
- After this change, if authors leave images without alt text, screen
readers will fallback to default behavior for missing alt text.
- Also with this change, Automated linting and testing tools will
correctly generate warnings.
[Fixes #30096 ]
2017-08-17 16:13:15 -04:00
Kir Shatrov
82df8c2ca5
Use frozen string literal in actionmailer/
2017-07-23 18:17:19 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Xavier Noria
b326e82dc0
applies remaining conventions across the project
2016-08-06 20:20:22 +02:00
Xavier Noria
b91ff557ef
applies new string literal convention in actionmailer/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:03:39 +02:00
schneems
e6b0b760cc
fix tests on action_mailer
...
Include appropriate helpers and use `assert_dom_equal` where applicable
2014-10-07 17:40:59 -05:00
Lucas Mazza
63f7b22a4e
Remove global helpers from the ActionMailer test suite.
2014-08-19 23:53:19 -03:00
Dmitry Polushkin
99f8d4feeb
add test coverage for the action mailer
2014-07-04 15:55:33 +01:00
Anupam Choudhury
2ff2f839ca
Refactored to remove unnecessary setup
2013-03-30 13:16:31 +05:30
Kirill Nikitin
96f290eac0
Update actionmailer with new hash syntax.
2012-10-07 21:54:14 +04:00
Aaron Patterson
5d09d395de
test cases should inherit from AS::TestCase
2012-01-05 17:05:43 -08:00
Dalibor Nasevic
e4cf28f3a0
Fixed typos in asset_host_test
...
[#6501 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2011-03-02 12:48:33 -02:00
José Valim
972efa11fd
Deprecate the old mailer API that was not deprecated yet.
2010-08-29 20:42:13 -03:00
José Valim and Mikel Lindsaar
bd96614101
Move old tests to a specific folder and add some delivery method tests.
2010-01-24 19:36:42 +01:00
José Valim and Mikel Lindsaar
f30d73bab4
Add new class delivery method API.
2010-01-24 17:31:18 +01:00
José Valim and Mikel Lindsaar
258ca14800
Delegated ActionMailer::Base.deliveries to Mail.deliveries, added callback support in Mail to call ActionMailer on delivery, moved deliver to deprecated API in preparation for new API
2010-01-24 11:15:42 +11:00
Mikel Lindsaar
331d375cc3
Changing body to use :to_s instead of :decoded... better use case
2009-12-27 20:56:16 +11:00
Mikel Lindsaar
15d7cac282
Starting again on actionmailer integration with mail
2009-11-12 16:08:50 +11:00
Tekin Suleyman
dab78e55cf
Ensure ActionMailer doesn't blow up when a two argument proc is set for the asset host
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1394 state:committed]
2008-12-01 19:38:25 +01:00
