1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

24 commits

Author SHA1 Message Date
Matthew Draper
ee5b621e2f Revert "Merge pull request #20851 from tomprats/indifferent-sessions"
This reverts commit 22db455dbe, reversing
changes made to 40be61dfda.

This finishes off what I meant to do in 6216a092cc.
2016-02-26 04:47:30 +10:30
Matthew Draper
6216a092cc Revert "Update Session to utilize indiffernt access"
This reverts commit 45a75a3fcc.

HWIAs are better than silently deeply-stringified hashes... but that's a
reaction to a shortcoming of one particular session store: we should not
break the basic behaviour of other, more featureful, session stores in
the process.

Fixes #23884
2016-02-26 03:06:38 +10:30
Tom Prats
45a75a3fcc Update Session to utilize indiffernt access 2016-01-30 19:30:32 -05:00
Tom Prats
82dc8266dd Update session to have indifferent access 2016-01-29 17:22:05 -05:00
Rebecca Skinner
99e9630ef8 Fix typo in docs [ci skip] 2016-01-14 11:04:08 +08:00
Akira Matsuda
d9bdb61158 Space Oddity
Converting nbsp(\u{00A0}) to the normal ASCII space(\u{0020})
[ci skip]
2016-01-14 10:36:54 +09:00
Aaron Patterson
bcfa2a0d5e stop using deprecated Abstract::ID class 2015-09-04 18:58:49 -07:00
Aaron Patterson
529136d670 stop inheriting from Rack::Request
Just include the modules necessary in the Request object to implement
the things we need.  This should make it easier to build delegate
request objects because the API is smaller
2015-09-04 17:37:22 -07:00
Aaron Patterson
5fe141638f use a request object in the session middleware
This commit allows us to use one request object rather than allocating
multiple request objects to deal with the session.
2015-08-22 17:57:45 -07:00
Aaron Patterson
51211a94bd point at rack master 2015-08-20 13:45:11 -07:00
Aaron Patterson
3692ca5ce7 don't hold a reference to env in the options object
I want to decouple Rails from the rack ENV as much as possible.  We
should try to keep as few references to the env as possible
2015-06-13 14:12:44 -07:00
Mehmet Emin İNAÇ
6709891c52 Add missing documentation for ActionDispatch::Request::Session [ci skip] 2015-06-07 23:58:16 +03:00
Bruce Park
164be37da5 remove new line between doc and method 2015-04-07 05:02:22 +00:00
Bruce Park
85eacc64a6 added docs for ActionDispatch::Request::Session#create 2015-04-07 01:23:51 +00:00
Trent Ogren
d0fc760d09 Make ActionDispatch::Request::Session#fetch behave like Hash#fetch
Session#fetch was mutating the session when given a default argument
and/or a block. Since Session duck-types as a Hash, it should behave
like one in these cases.
2013-12-11 15:29:33 -06:00
Damien Mathieu
84c9f4164b add the fetch method to sessions 2013-10-29 20:37:15 +01:00
Carlos Antonio da Silva
7d624e0e8c Integrate Action Pack with Rack 1.5
All ActionPack and Railties tests are passing. Closes #8891.

[Carlos Antonio da Silva + Santiago Pastorino]
2013-01-25 17:28:41 -02:00
Aaron Patterson
abd47c15b8 Merge pull request #7495 from steveklabnik/issue_7478
Properly reset the session on reset_session
2012-09-01 23:42:39 -07:00
Andreas Loupasakis
8bfcb0de3a Force reloading of the session after destroy
Use load_for_write! to ensure a refresh of the session object.
This way the new session_id and the empty data will be stored properly.
E.g. in the case of the session cookie store this means that a new
digest will be returned to the user.
2012-09-01 16:35:52 -07:00
Andreas Loupasakis
54a0b01f76 Assign a new session_id to session options hash 2012-09-01 16:35:32 -07:00
Steve Klabnik
a91c7b4006 Fix comment about Session.
SessionHash isn't a thing, and tenses are wrong.
2012-08-31 11:20:04 -07:00
Philip Arndt
6ac458d341 Added ActionDispatch::Request::Session#keys and ActionDispatch::Request::Session#values 2012-05-23 14:47:30 +12:00
Aaron Patterson
d5cc711307 need to dup the default options so that mutations will not impact us 2012-05-04 15:55:57 -07:00
Aaron Patterson
c4f02295df bread AD::Request::Session to it's own file, consolidate HASH OF DOOM lookups 2012-05-03 14:28:11 -07:00