kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
55428 commits 72 branches 493 tags 355 MiB
Commit graph

13 commits

Author SHA1 Message Date
Aaron Patterson
c42db41f54 routes are always constructed with a hash for the conditions 2015-08-17 16:30:53 -07:00
Aaron Patterson
1ce74b009f introduce an alternate constructor for Route objects 
I want to change the real constructor to take a particular parameter for
matching the request method
 2015-08-17 16:08:39 -07:00
Aaron Patterson
e9777ef62e default pattern to use a joined string 
The string we create is almost always the same, so rather than joining
all the time, lets join once, then reuse that string everywhere.
 2015-08-17 13:51:38 -07:00
Aaron Patterson
947ebe9a6d remove Strexp 
This was a useless object.  We can just directly construct a
Path::Pattern object without a Strexp object.
 2015-08-13 15:42:46 -07:00
Aaron Patterson
4868692687 pass anchor directly to Pattern 
the caller already has it, there is no reason to pack it in to an object
and just throw that object away.
 2015-08-13 15:16:25 -07:00
Aaron Patterson
8037d7eacd extract required_defaults from the conditions hash before constructing the route 
this way we can remove the strange "respond_to?" conditional in the
`matches?` loop
 2015-06-08 17:18:32 -07:00
Prem Sichanugrist
7cb9e20c6c Silence ambiguous first argument warning 
This silences:

    actionpack/test/journey/route_test.rb:33: warning: ambiguous first
    argument; put parentheses or a space even after `/' operator
 2015-05-04 10:15:50 -04:00
brainopia
f9e2496872 Correct route requirements by overriding defaultls (fixes #18373) 2015-01-08 02:53:57 +03:00
Aaron Patterson
bb207ea7b6 Path::Pattern is instantiated internally, so make the contructor require a strexp object 2014-05-29 15:44:54 -07:00
Andrew White
f1d8f2af72 Change the behavior of route defaults 
This commit changes route defaults so that explicit defaults are no
longer required where the key is not part of the path. For example:

  resources :posts, bucket_type: 'posts'

will be required whenever constructing the url from a hash such as a
functional test or using url_for directly. However using the explicit
form alters the behavior so it's not required:

  resources :projects, defaults: { bucket_type: 'projects' }

This changes existing behavior slightly in that any routes which
only differ in their defaults will match the first route rather
than the closest match.

Closes #8814
 2013-01-15 17:22:25 +00:00
Rafael Mendonça França
dc8091b88f Use ActiveSupport::TestCase in the journey tests 2012-12-31 14:40:43 -03:00
Rafael Mendonça França
5294ad82c6 Alias refute methods to assert_not and perfer assert_not on tests 2012-12-31 13:58:52 -03:00
Andrew White
56fee39c39 Integrate Journey into Action Dispatch 
Move the Journey code underneath the ActionDispatch namespace so
that we don't pollute the global namespace with names that may
be used for models.

Fixes rails/journey#49.
 2012-12-19 22:13:08 +00:00