kotovalexarian-likes-github/rails--rails

Commit Graph

Author	SHA1	Message	Date
Jonathan Hefner	614e813161	Disentangle Action Text from ApplicationController This commit allows Action Text to be used without having an ApplicationController defined. In doing so, it also fixes Action Text attachments to render the correct URL host in mailers. It also avoids allocating an ActionController::Renderer per request. Fixes #37183. Fixes #35578. Fixes #36963. Closes #38714. Co-authored-by: Jeremy Daer <jeremydaer@gmail.com>	2020-10-30 01:01:42 +00:00
Akira Matsuda	530f7805ed	It may be better to explicitly require 'object/try' where we call `try` In most cases it works now without explicit require because it's accidentally required through active_support/core_ext/date_and_time/calculations.rb where we still call `try`, but that would stop working if we changed the Calculations implementation and remove the require call there.	2019-08-01 18:51:51 +09:00
George Claghorn	0decd2ddc4	Import Action Text	2019-01-04 22:22:49 -05:00

Author

SHA1

Message

Date

Jonathan Hefner

614e813161

Disentangle Action Text from ApplicationController

This commit allows Action Text to be used without having an
ApplicationController defined.  In doing so, it also fixes Action Text
attachments to render the correct URL host in mailers.

It also avoids allocating an ActionController::Renderer per request.

Fixes #37183.
Fixes #35578.
Fixes #36963.
Closes #38714.

Co-authored-by: Jeremy Daer <jeremydaer@gmail.com>

2020-10-30 01:01:42 +00:00

Akira Matsuda

530f7805ed

It may be better to explicitly require 'object/try' where we call `try`

In most cases it works now without explicit require because it's accidentally required through
active_support/core_ext/date_and_time/calculations.rb where we still call `try`,
but that would stop working if we changed the Calculations implementation and remove the require call there.

2019-08-01 18:51:51 +09:00

George Claghorn

0decd2ddc4

Import Action Text

2019-01-04 22:22:49 -05:00

3 Commits