Commit Graph

25 Commits

Author SHA1 Message Date
John Hawthorn dd5cbf58ed Don't modify relative ./ paths in BacktraceCleaner
Previously a path starting with ./ would be replaced to start with /.
IMO this didn't particularly make sense since / reads as though it's
from the root of the filesystem.

This commit removes that filter, preserves ./, and updates the silencer
not to remove lines starting with ./
2019-10-03 14:06:58 -07:00
John Hawthorn 0bab6310d6 Find query_source_location using lazy Enumerator
This way, we only need to filter the backtrace up to the first non-noise
stack frame.

This also updates noise to be able to deal with being passed a lazy
enum. We don't need this anywhere, but it seemed better for this to be
consistent.
2019-04-15 16:13:06 -07:00
yuuji.yaginuma 788272231c Fix "DEPRECATION WARNING: ActionView::Template#initialize requires a locals parameter"
Ref: #35411
2019-03-09 07:54:37 +09:00
Lachlan Sylvester c675783eb4 Use backtrace cleaner to clean up backtrace for verbose query logs 2018-08-14 09:15:28 +10:00
Lachlan Sylvester e69dfa478b update BacktraceCleaner::RENDER_TEMPLATE_PATTERN to match the ActionView::Template method names 2018-08-07 16:10:00 +10:00
Lachlan Sylvester 67c58f4884 Filter backtrace in test to ensure irb counts as user code 2018-08-06 15:40:49 +10:00
Pat Allan acea68de02 Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
yuuji.yaginuma 93b7816eef use correct variable in BacktraceCleaner test
`@target_dir` variable was changed to local variable in 8e1714b.
2016-11-26 10:55:11 +09:00
Xavier Noria 783763bde9 applies new string literal convention in railties/test
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:16:09 +02:00
Vipul A M 8e1714b2f5
- Added test for verifying that we treat line number indications from irb as user/lib code
- Cleaned up backtrace cleaner test code and removed instaces variables
2016-07-01 16:57:45 -07:00
Roman V. Babenko e17cc4d493 Gem cont presence checking has been removed 2012-05-02 13:56:13 +03:00
Rafael Mendonça França f9382cd794 Test::Unit::Util::BacktraceFilter is never defined 2012-01-06 20:42:53 -03:00
Joshua Peek eb39d0f7b9 Use backtrace cleaner for dev mode exception page 2010-01-16 21:34:35 -06:00
Jeremy Kemper 322b6b29c2 test-unit 2: filter_backtrace is private 2009-11-10 21:04:00 -08:00
Joshua Peek fa1926ddaa Exclude gem backtrace filter if rubygems is not loaded 2009-10-20 09:32:26 -05:00
Mike Gunderloy 77bb129fdb Fix bad assumption in BacktraceCleaner test [#3249 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-10-18 17:17:09 -02:00
Carl Lerche e1fdc8bba3 Remove config.gem in favor of using the bundler. This makes config/boot.rb obsolete.
The bundler library is at: http://github.com/wycats/bundler/ and is a rubygem.
2009-10-16 18:10:52 -07:00
Carl Lerche 2110a524a4 Deprecate RAILS_ROOT in favor of Rails.root (which proxies to the application's object root) 2009-10-16 12:51:02 -07:00
Joshua Peek 79a4d505fa Add gem filter for default gem path since it maybe different than the set of gem paths 2009-09-26 11:04:08 -05:00
Yehuda Katz + Carl Lerche f0dd77c6be Move railties/lib/* into railties/lib/* 2009-09-24 16:11:41 -07:00
Matt Jones 0da8e45baf Correctly clean backtraces from vendor/gems and gems in alternate install locations
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
2009-03-09 12:49:58 +01:00
Jeremy Kemper 1ceddd9514 Skip backtrace filter test when using minitest 2009-02-27 12:18:45 -08:00
Manfred Stienstra 1f48c09094 Accept a prefix argument to filter_backtrace_with_cleaning [#1456 state:committed]
Add a prefix argument to filter_backtrace_with_cleaning so it has
the same arity as test/unit's filter_backtrace.

Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
2008-11-24 11:35:55 +01:00