kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity
75283 commits 72 branches 493 tags 355 MiB
Commit graph

22 commits

Author SHA1 Message Date
Ryuta Kamizono
44bee7f242 Revert "Merge pull request #34421 from albertoalmagro/use-assert-not-instead-of-refute" 
This reverts commit ab5d5c95ec, reversing
changes made to ef4f5ef69b.
 2018-11-11 12:35:55 +09:00
Alberto Almagro
2d749cbea9 Prefer assert_not instead of refute [ci skip] 
As mentioned in the contributing to Ruby on Rails guides,
we should prefer `assert_not` instead of `refute`. And the
best place to start giving example are our bug report templates..

See: https://github.com/rails/rails/blame/master/guides/source/contributing_to_ruby_on_rails.md#L256
 2018-11-10 21:49:11 +01:00
Robin Dupret
f1e4d3d8dd Update bug report templates 
Given that Bundler 1.10 was released back in 2015, we can assume
that people are at least on this version or a higher one so there
is no need to ask people to upgrade.

Also, given that Rails 5.0 supports Ruby 2.2+ and given that this
version come with Minitest 5.4.3 bundled, we don't need to ensure
backward compatibility with Minitest 4.
 2018-10-28 18:12:48 +01:00
SHIBATA Hiroshi
fd6522a4b4 Revert "Specify bundler version in template files" 
This reverts commit b106242f52.
 2017-12-22 23:07:14 +09:00
yuuji.yaginuma
2a26ff80e8 Use released arel 
Related to 2e0fe5928f
 2017-11-15 10:00:43 +09:00
yuuji.yaginuma
b106242f52 Specify bundler version in template files 
We have already specified to install `bundler` 1.15.4 in `.travis.yml`.
https://github.com/rails/rails/blob/master/.travis.yml#L31..L32

However, `bundler` 1.16.0 may be used in the test.
https://travis-ci.org/rails/rails/jobs/296582467#L2208

The test failed due to this influence.
In order to avoid this, specifying `bundler` version in bug report
templates.
 2017-11-03 22:25:47 +09:00
Ryuta Kamizono
a151d8ad89 Add newlines before/after the git_source in bug report templates 
[ci skip]
 2017-09-27 17:55:43 +09:00
bogdanvlviv
3e0a858aed
Change :github git source for bug report templates 
:github source uses `git://` url by default, `https://` is recommended.
See http://bundler.io/v1.15/guides/git.html#security

We do the same in our `Gemfile` and templates.
 2017-09-27 00:02:11 +03:00
Koichi ITO
1f37d846a9 Use frozen string literal in guides/ 2017-08-13 22:04:09 +09:00
Matthew Draper
87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
 2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
Matthew Draper
6c08d480f1 Start Rails 5.2 development 2017-03-22 10:11:39 +10:30
Rafael Mendonça França
ea9566f6cd
Use released arel 2017-02-21 11:46:42 -05:00
Rafael Mendonça França
e646bad5b7
Remove deprecated support to passing a column to #quote 2016-12-29 17:53:03 -05:00
Xavier Noria
6b3719b757 applies new string literal convention in guides 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:21:59 +02:00
Rafael Mendonça França
454bc1deab Remove github gems from the master bug report templates 
All gems are released now so we don't need to ask the github repository
for these gems anymore.
 2016-02-18 15:35:45 -02:00
yuuji.yaginuma
92cca41bbe remove backward compatibility code for Minitest 4 
The master branch is required Ruby 2.2.2+, for the Ruby 2.2 is bundled Minitest 5.4.3,
I think backward compatibility code for Minitest 4 is unnecessary.
 2016-01-30 16:52:09 +09:00
claudiob
9ddd1c4451 Fix: make Travis CI happy about guides again 
Tests on Rails [are currently failing](https://travis-ci.org/rails/rails/jobs/78255666).

The reason is the dependency of Rails master from gems that are currently on
GitHub (not on RubyGems) and should be explicitly referenced in the Guides
test files.
 2015-09-01 10:00:06 -07:00
Aaron Patterson
7354ef146e argh!!! 2015-08-20 13:55:48 -07:00
akihiro17
b07483490f Output an error message and raise an error if bundler 1.10.x is not installed when reporting bugs 2015-06-06 23:09:46 +09:00
Roque Pinel
ebd806cf4b Use inline Gemfile dependency when reporting bugs 
With Bundler `1.10.3`, it is possible to list the gems inline without the
need to create a `Gemfile` if none is found in the current directory.
 2015-06-03 22:02:25 -05:00
Godfrey Chan
ee43a67c2c Add a "generic" bug report template 
This template gives contributors a starting point to use when reporting bugs
that does not involve Active Record or Action Pack.
 2015-04-19 15:18:01 -07:00