1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

12 commits

Author SHA1 Message Date
Xavier Noria
92d03850f3 files -> directories in zeitwerk:check warning [skip ci] 2020-04-29 11:12:46 +02:00
Peter Baker
f61d5b4767 Improve zeitwerk:check warning message.
The messages that are printed to the console when users run rails zeitwerk:check
can be a little confusing if they've generated a mailer, as the test files aren't
included by default, and a warning appears about this.

To address this issue the warning message has been improved so that it is clearer
that this behaviour is normal and it explicitly states that the user must configure
eager loading to silence these warnings. Fixes #38156
2020-02-02 15:18:23 +00:00
Xavier Noria
35c5aa104a quick regression fix for zeitwerk:check 2019-12-16 20:08:32 +01:00
Xavier Noria
63a791c097 remove spurious trailing commas from zeitwerk:check error messages
Since the original message is something like this

    expected file ... to define constant A, but didn't

the \S+ captured the comma. A constant name goes there, so [\w:]+ is
enough and won't match the comma.
2019-09-25 00:41:39 +02:00
Xavier Noria
ac193d0cc3 actual fix for #37285 2019-09-25 00:27:18 +02:00
Xavier Noria
3ac9e22c12 let zeitwerk:check report files outside the root directory with absolute paths
This may happen in engines loaded as gems, for example.

Closes #37285.
2019-09-24 10:27:18 +02:00
Xavier Noria
938d18d09a improves zeitwerk:check 2019-07-12 23:44:44 +02:00
Xavier Noria
43ae74f6f6 make sure zeitwerk:check only deals with directories [closes #36461] 2019-07-12 18:11:58 +02:00
Xavier Noria
4829214aa2 adds a blank line [ci skip] 2019-05-13 06:00:28 +02:00
Xavier Noria
63f39dd6eb warn about non-eager loaded dirs in zeitwerk:check 2019-05-13 05:49:00 +02:00
Ryuta Kamizono
c1ff1392db Fix rubocop offences 2019-04-30 18:32:41 +09:00
Xavier Noria
afc17e5ea2 Implements the task zeitwerk:check
[Matilda Smeds & Xavier Noria]
2019-04-23 03:17:34 +02:00