1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

16 commits

Author SHA1 Message Date
Ryuta Kamizono
60bfed90ce Revert "Lock benchmark-ips version "< 2.8""
This reverts commit c1b8833edb.

Revert "Lock benchmark-ips version < 2.8"

This reverts commit 62bfa50ff2.

LoadError is fixed in benchmark-ips 2.8.2.

https://github.com/evanphx/benchmark-ips/pull/101
2020-06-05 10:22:27 +09:00
Ryuta Kamizono
c1b8833edb Lock benchmark-ips version "< 2.8"
Looks like benchmark-ips 2.8.0 is broken.

https://buildkite.com/rails/rails/builds/68583#cefd24fb-33e5-4967-ab5d-f52c46700cd7/1879-1934
2020-05-02 06:19:38 +09:00
Robin Dupret
f1e4d3d8dd Update bug report templates
Given that Bundler 1.10 was released back in 2015, we can assume
that people are at least on this version or a higher one so there
is no need to ask people to upgrade.

Also, given that Rails 5.0 supports Ruby 2.2+ and given that this
version come with Minitest 5.4.3 bundled, we don't need to ensure
backward compatibility with Minitest 4.
2018-10-28 18:12:48 +01:00
SHIBATA Hiroshi
fd6522a4b4 Revert "Specify bundler version in template files"
This reverts commit b106242f52.
2017-12-22 23:07:14 +09:00
yuuji.yaginuma
2a26ff80e8 Use released arel
Related to 2e0fe5928f
2017-11-15 10:00:43 +09:00
yuuji.yaginuma
b106242f52 Specify bundler version in template files
We have already specified to install `bundler` 1.15.4 in `.travis.yml`.
https://github.com/rails/rails/blob/master/.travis.yml#L31..L32

However, `bundler` 1.16.0 may be used in the test.
https://travis-ci.org/rails/rails/jobs/296582467#L2208

The test failed due to this influence.
In order to avoid this, specifying `bundler` version in bug report
templates.
2017-11-03 22:25:47 +09:00
Ryuta Kamizono
a151d8ad89 Add newlines before/after the git_source in bug report templates
[ci skip]
2017-09-27 17:55:43 +09:00
bogdanvlviv
3e0a858aed
Change :github git source for bug report templates
:github source uses `git://` url by default, `https://` is recommended.
See http://bundler.io/v1.15/guides/git.html#security

We do the same in our `Gemfile` and templates.
2017-09-27 00:02:11 +03:00
Koichi ITO
1f37d846a9 Use frozen string literal in guides/ 2017-08-13 22:04:09 +09:00
Sean Griffin
0267019a55 Require arel master in the benchmark template
Pointing at Rails master generally requires pointing at Arel master
2017-07-25 15:50:10 -04:00
Matthew Draper
87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
Rafael Mendonça França
ea9566f6cd
Use released arel 2017-02-21 11:46:42 -05:00
Rafael Mendonça França
e646bad5b7
Remove deprecated support to passing a column to #quote 2016-12-29 17:53:03 -05:00
Rafael Mendonça França
fe1f4b2ad5
Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
Godfrey Chan
f2f9b88685 Introduce a benchmark template [ci skip]
This replaces boilerplate in the “benchmark your code” section of the
contributors’ guide with an executable template. I also amended the text
to encourage best practices and codified it in the template.

For now this is only good for relatively self-contained changes that can
be inlined into a simple script. In the future, this can be expanded to
cover how to measure the difference between two commits.

The output looks like this:

```
==================================== Empty =====================================

Warming up --------------------------------------
              blank?   225.963k i/100ms
         fast_blank?   238.147k i/100ms
Calculating -------------------------------------
              blank?      8.825M (± 6.4%) i/s -     44.063M in   5.014824s
         fast_blank?      9.311M (± 6.3%) i/s -     46.439M in   5.009153s

Comparison:
         fast_blank?:  9310694.8 i/s
              blank?:  8824801.7 i/s - same-ish: difference falls within error


================================= Single Space =================================

Warming up --------------------------------------
              blank?    56.581k i/100ms
         fast_blank?   232.774k i/100ms
Calculating -------------------------------------
              blank?    813.985k (±16.7%) i/s -      4.017M in   5.076576s
         fast_blank?      9.547M (± 5.2%) i/s -     47.719M in   5.013204s

Comparison:
         fast_blank?:  9547414.0 i/s
              blank?:   813985.0 i/s - 11.73x  slower


================================== Two Spaces ==================================

Warming up --------------------------------------
              blank?    58.265k i/100ms
         fast_blank?   244.056k i/100ms
Calculating -------------------------------------
              blank?    823.343k (±16.2%) i/s -      4.020M in   5.014213s
         fast_blank?      9.484M (± 4.9%) i/s -     47.347M in   5.005339s

Comparison:
         fast_blank?:  9484021.6 i/s
              blank?:   823343.1 i/s - 11.52x  slower


=============================== Mixed Whitspaces ===============================

Warming up --------------------------------------
              blank?    53.919k i/100ms
         fast_blank?   237.103k i/100ms
Calculating -------------------------------------
              blank?    763.435k (±16.8%) i/s -      3.720M in   5.018029s
         fast_blank?      9.672M (± 5.8%) i/s -     48.369M in   5.019356s

Comparison:
         fast_blank?:  9672467.2 i/s
              blank?:   763435.4 i/s - 12.67x  slower


=============================== Very Long String ===============================

Warming up --------------------------------------
              blank?    34.037k i/100ms
         fast_blank?   240.366k i/100ms
Calculating -------------------------------------
              blank?    409.731k (± 8.9%) i/s -      2.042M in   5.028235s
         fast_blank?      9.794M (± 4.3%) i/s -     49.035M in   5.016328s

Comparison:
         fast_blank?:  9794225.2 i/s
              blank?:   409731.4 i/s - 23.90x  slower
```
2016-10-15 12:34:46 +02:00