Étienne Barrié
f1cef4c9ca
Remove invalid autoloads in top-level Rails modules
2020-06-08 17:21:26 -04:00
Ryuta Kamizono
c81af6ae72
Enable Layout/EmptyLinesAroundAccessModifier cop
...
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776 ,
https://github.com/rails/rails/pull/34832#discussion_r244847195 ).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059 ).
That cop and enforced style will reduce the our code review cost.
2019-06-13 12:00:45 +09:00
Ryuta Kamizono
892e38c78e
Enable Style/RedundantBegin cop to avoid newly adding redundant begin block
...
Currently we sometimes find a redundant begin block in code review
(e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205 ).
I'd like to enable `Style/RedundantBegin` cop to avoid that, since
rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5
(https://bugs.ruby-lang.org/issues/12906 ), so we'd probably meets with
that situation than before.
2018-12-21 06:12:42 +09:00
Kir Shatrov
385825fb70
Use frozen string literal in actioncable/
2017-07-23 23:30:29 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Matthew Draper
a92fa72600
Shut down the worker pool - don't kill it
...
Different parts of concurrent-ruby's documentation make inconsistent
claims about how kill will behave. It doesn't do the thing we want.
2016-10-03 05:38:25 +10:30
Xavier Noria
b678eb57e9
applies new string literal convention in actioncable/lib
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:13:46 +02:00
Jeremy Daer
ba9571e1ac
Periodic timers: delegate async instance_exec to the worker pool
2016-06-29 23:37:07 -07:00
Jeremy Daer
3ba0eec20c
Cable: Extract stream handler construction
...
* Use separate stream handler builders for easy override and testing.
* Fix worker pool execution that was silently failing since it only
expected connection receivers.
Sparked by code in #24162 .
2016-04-18 23:29:51 -07:00
Jeremy Daer
983b743c8c
Cable: Periodic timers refresh
...
* Rewrite docs
* Support blocks in addition to method names and Proc args
* Check for valid arguments
* Convert `periodically :method_name` to Proc callbacks
* Drop periodic runner methods from the worker pool
* Ensure we clear active periodic timers after shutdown
2016-04-18 13:08:22 -07:00
Matthew Draper
185c93eb0c
Use AS::Executor / AS::Reloader to support reloading in ActionCable
2016-03-02 02:14:20 +10:30
Jon Moss
05088b6299
Full Action Cable documentation read through
...
This PR checks all active Action Cable documentation for typos and other
fixes. It aims to make sure that when Rails 5 is released, that the
Action Cable docs are up to snuff with the other documentation included
with Rails.
[ci skip]
2016-02-17 11:08:00 -05:00
David Heinemeier Hansson
01c320001b
Revert "Merge pull request #22977 from rails/revert-22934-master"
...
This reverts commit d0393fccff3b7ccadfc1
2016-01-16 15:42:20 +01:00
David Heinemeier Hansson
36fe301564
Revert "Move async execution from celluloid to concurrent-ruby"
2016-01-08 20:09:25 +01:00
Mike Perham
cd1d7e287b
don't need explicit dep and a pretty neat pick
2016-01-05 16:26:53 -08:00
Mike Perham
e529e3428e
Use Module#thread_mattr_accessor
2016-01-05 15:11:10 -08:00
Mike Perham
547713b4c9
Move async execution from celluloid to concurrent-ruby
...
This removes 8 runtime gem dependencies from Rails:
```
Using hitimes 1.2.3
Using timers 4.1.1
Using celluloid-essentials 0.20.5
Using celluloid-extras 0.20.5
Using celluloid-fsm 0.20.5
Using celluloid-pool 0.20.5
Using celluloid-supervision 0.20.5
Using celluloid 0.17.2
```
2016-01-05 14:31:16 -08:00
David Heinemeier Hansson
bf40bddfce
Get ready to merge into Rails
2015-12-14 15:48:54 +01:00
