Ryuta Kamizono
c81af6ae72
Enable Layout/EmptyLinesAroundAccessModifier cop
...
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776 ,
https://github.com/rails/rails/pull/34832#discussion_r244847195 ).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059 ).
That cop and enforced style will reduce the our code review cost.
2019-06-13 12:00:45 +09:00
Kir Shatrov
424117281e
Use frozen string literal in actionview/
2017-07-24 11:53:43 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Rafael Mendonça França
fe1f4b2ad5
Add more rubocop rules about whitespaces
2016-10-29 01:17:49 -02:00
Xavier Noria
b326e82dc0
applies remaining conventions across the project
2016-08-06 20:20:22 +02:00
Xavier Noria
80e66cc4d9
normalizes indentation and whitespace across the project
2016-08-06 20:16:27 +02:00
Xavier Noria
66a7cfa910
applies new string literal convention in actionview/lib
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:48:35 +02:00
Alex Mirkhaydarov
8e092f2b72
Improved ActionView flows.rb documention [ci skip]
2016-04-11 21:01:26 +01:00
Yoong Kang Lim
7c988f8030
Use ActiveSupport::SafeBuffer when flushing content_for
...
Previously, when content_for is flushed, the content
was replaced directly by a new value in
ActionView::OutputFlow#set. The problem is this new
value passed to the method may not be an instance of
ActiveSupport::SafeBuffer.
This change forces the value to be set to a new
instance of ActiveSupport::SafeBuffer.
2015-05-25 22:13:03 +10:00
Ryan Williams
7acbe60328
Comment typo
2013-06-25 14:34:51 -04:00
Piotr Sarnacki
0d6e8edc2a
Move actionpack/lib/action_view* into actionview/lib
2013-06-20 17:23:15 +02:00
