10 commits

Author	SHA1	Message	Date
Ryuta Kamizono	c81af6ae72	Enable Layout/EmptyLinesAroundAccessModifier cop ... We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.	2019-06-13 12:00:45 +09:00
neumayr	ead4776b82	Fix field_error_proc wrap form select optgroup and divider option tag ... ### Summary The [`:field_error_proc`](https://github.com/rails/rails/blob/master/actionview/lib/action_view/base.rb#L145) is responsible for decorating input tags that refer to attributes with errors. This default build-in rails feature wrap invalid form elements with additional markup: `<div class="field_with_errors">[…]</div>`. * Fix for `field_error_proc` wraps form select `optgroup` * Fix for `field_error_proc` wraps form select divider `option` * Add tests for uncovered elements with errors [Fixes #31088] #### Test coverage * `test_select_grouped_options_with_errors` * `test_time_zone_select_with_priority_zones_and_errors` #### Extend test coverage * `test_collection_select_with_errors` * `test_label_with_errors` * `test_check_box_with_errors` * `test_check_boxes_with_errors` * `test_radio_button_with_errors` * `test_radio_buttons_with_errors` * `test_collection_check_boxes_with_errors` * `test_collection_radio_buttons_with_errors`	2017-11-09 17:37:06 +01:00
Yoshiyuki Hirano	9740a59aee	Fix broken doc layout for action_view [ci skip]	2017-08-27 09:12:19 +09:00
Kir Shatrov	424117281e	Use frozen string literal in actionview/	2017-07-24 11:53:43 +03:00
Matthew Draper	87b3e226d6	Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" ... This reverts commit 3420a14590, reversing changes made to afb66a5a59.	2017-07-02 02:15:17 +09:30
Kir Shatrov	cfade1ec7e	Enforce frozen string in Rubocop	2017-07-01 02:11:03 +03:00
Xavier Noria	80e66cc4d9	normalizes indentation and whitespace across the project	2016-08-06 20:16:27 +02:00
Xavier Noria	66a7cfa910	applies new string literal convention in actionview/lib ... The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.	2016-08-06 18:48:35 +02:00
Genadi Samokovarov	6329d9fa8b	Remove deprecated cattr_* requires	2013-12-03 00:28:15 +02:00
Piotr Sarnacki	0d6e8edc2a	Move actionpack/lib/action_view* into actionview/lib	2013-06-20 17:23:15 +02:00

Renamed from actionpack/lib/action_view/helpers/active_model_helper.rb (Browse further)