Dillon Welch
d108288c2f
Turn on performance based cops
...
Use attr_reader/attr_writer instead of methods
method is 12% slower
Use flat_map over map.flatten(1)
flatten is 66% slower
Use hash[]= instead of hash.merge! with single arguments
merge! is 166% slower
See https://github.com/rails/rails/pull/32337 for more conversation
2018-07-23 15:37:06 -07:00
James Lovejoy
49542ae886
Fix typos, update documentation
...
[ci skip]
2018-01-11 17:10:06 -08:00
Kir Shatrov
82df8c2ca5
Use frozen string literal in actionmailer/
2017-07-23 18:17:19 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Eugene Kenny
ebededb372
Don't mutate raw_source in mailer preview interceptor
...
The raw_source method is documented as returning the exact value that
was used to create the body; mutating it breaks that contract.
Additionally, if the value used to create the body is blank, raw_source
returns a frozen string which causes the interceptor to raise an error.
2017-01-30 22:20:47 -07:00
Rafael Mendonça França
fe1f4b2ad5
Add more rubocop rules about whitespaces
2016-10-29 01:17:49 -02:00
Rafael Mendonça França
55f9b8129a
Add three new rubocop rules
...
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces
Fix all violations in the repository.
2016-08-16 04:30:11 -03:00
Xavier Noria
c3e7abddfb
applies new string literal convention in actionmailer/lib
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:01:31 +02:00
Santosh Wadghule
136f17458b
Change 'a HTML' to 'an HTML' [ci skip]
2016-03-03 19:33:00 +05:30
Rafael Mendonça França
b42d770b3b
Make the wording less confusing
...
This partially reverts commit ac02df5c78
2015-05-29 15:24:13 -03:00
Manish Puri
ac02df5c78
Update inline_preview_interceptor.rb
2015-05-29 13:44:46 -04:00
Andrew White
faaed863dd
Document inline image mailer preview interceptor
...
Explain what the interceptor is used for and how to remove it.
2015-05-04 19:46:51 +01:00
