Kir Shatrov
d7b1521db8
Use frozen string literal in activemodel/
2017-07-16 20:11:16 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Xavier Noria
4c20825457
applies new string literal convention in activemodel/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:38:23 +02:00
Aditya Kapoor
2399207789
[ci skip] add tests for ActionModel::Conversion
2014-06-11 23:18:47 +05:30
Yves Senn
7d196cf360
#to_param returns nil if to_key returns nil. Closes #11399 .
...
The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key )
states that it returns `nil` if there are no key attributes. `to_param` needs
to be aware of that fact and return `nil` as well.
Previously it raised the following exception:
```
1) Error:
ConversionTest#test_to_param_returns_nil_if_to_key_is_nil:
NoMethodError: undefined method `join' for nil:NilClass
/Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param'
/Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>'
```
2014-02-04 10:27:46 +01:00
Patrick Robertson
eebb9ddf9b
Convert ActiveModel to 1.9 hash syntax.
...
I also attempted to fix other styleguide violations such as
{ a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
2013-05-01 18:01:46 -07:00
Yves Senn
bc19c0d09c
test for ActiveModel::Conversion#to_partial_path and namespaced models
2013-01-14 21:17:22 +01:00
Grant Hutchins
e78c5eeba1
Fix comments about to_partial_path
2012-03-10 17:40:27 -05:00
José Valim
dc8773b19f
Rename new method to_path to to_partial_path to avoid conflicts with File#to_path and similar.
2011-08-01 11:42:00 +02:00
Grant Hutchins & Peter Jaros
bf812074fd
Let ActiveModel instances define partial paths.
...
Deprecate ActiveModel::Name#partial_path. Now you
should call #to_path directly on ActiveModel
instances.
2011-07-25 16:05:24 -04:00
José Valim
250c809246
Require persisted? in ActiveModel::Lint and remove new_record? and destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not.
2010-02-21 11:12:14 +01:00
José Valim
9dd67fce25
Add to_key and to_param methods to ActiveModel::Conversion.
2010-02-21 09:08:59 +01:00
