1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

25 commits

Author SHA1 Message Date
Alex Tambellini
f1d9179087 Remove privatizing of Fixnum#/ from assert_distance_of_time_in_words
MRI reimplemented Date in C so it doesn't hit this division anymore
while JRuby still uses the old stdlib implementation of Date so
it will always hit this.

With this change the actionview date_helper_test.rb tests should pass on JRuby.
2013-08-05 21:52:13 -04:00
Guillermo Iguaran
ee0a8e0113 Merge pull request #11743 from gaurish/tmp-magic
[Jruby] Make all tests in ActionView::TemplateDigestorTest green
2013-08-05 17:04:57 -07:00
Gaurish Sharma
4254a6e677 Add tmp dir in actionview/test/
Missing tmp directory will cause the test to fail on JRuby. will commit
adds tmp directory & 22 TemplateDigestorTests which were failing before
are now green.

Further Discussion on this can be seen at #11743
2013-08-05 01:24:14 +05:30
Nathan Stitt
0855f041df Add "extname" option to javascript_include_tag
ActionView::Helpers.asset_path is where the logic for
javascript_include_tag resides.  It takes an extname option for
specifying the extension or false to not append it.  This exposes that
option to javascript_include_tag.

Without the option files that didn't end with ".js" would get the
extension appended to them.  This broke JST templates and other file
types that should be interpreted as JavaScript but who's file extension
isn't ".js"
2013-08-03 09:30:06 -05:00
Rafael Mendonça França
b3c0858f73 Make current_page? compare binary strings 2013-08-01 17:59:25 -03:00
Rafael Mendonça França
69339e54d3 Fix current_page? when the URL contains escaped characters
In some cases webservers like nginx send the escaped characters
lowercased to the Rails application. The current_page? helper was
comparing the escaped strings that are different since Ruby escapes the
URL using uppercased characters.
2013-08-01 10:46:35 -03:00
Joel Cogen
1424873948 text_area should handle nil value option like text_field 2013-07-24 08:39:17 +02:00
Vasiliy Ermolovich
cadfe4bf45 add support for html attributes to grouped_options_for_select 2013-07-20 17:14:28 +03:00
Vipul A M
ad3916d133 Fix test name typos 2013-07-19 20:15:14 +05:30
kennyj
ca85caca0d Fix default rendered format problem when calling render method without :content_type option. Closes #11393. 2013-07-15 02:11:43 +09:00
Rafael Mendonça França
9eeb3cc040 Merge pull request #11348 from sanemat/fix/link-to-block
Fix actionview link_to with block and url_hash
2013-07-07 10:02:39 -07:00
Rafael Mendonça França
09f6fe1cd4 Fix "Stack Level Too Deep" error when rendering recursive partials
When rendering recursive partial Action View is trying to generate the
view digest infinitly causing a stack level error.

Fixes #11340
2013-07-07 13:44:16 -03:00
Takayuki Matsubara
06388b0779 Added an enforce_utf8 hash option for form_tag method
Control to output a hidden input tag with name `utf8` without monkey
patching

Before:

    form_tag
    # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>'

After:

    form_tag
    # => '<form>..<input name="utf8" type="hidden" value="&#x2713;" />..</form>'

    form_tag({}, { :enforce_utf8 => false })
    # => '<form>....</form>'
2013-07-07 23:49:38 +09:00
sanemat
f71b075d6c Fix link_to with block and url_hash
Use link_to with block and url_hash, expect block as name.
But ignore block and use url_hash as name.
3-2-stable passes this test. 4-0-stable and master fail this.
2013-07-07 23:21:47 +09:00
sanemat
56e3419fef Remove action view test duplication
Same test exists above 2 or 3 lines.
2013-07-07 00:59:30 +09:00
Vipul A M
38aafc0377 Remove FormBuilder deprecation warning about block argument and associated tests 2013-07-02 02:06:39 +05:30
Jon Rowe
53eb9fdd9c fetch value(s) from stringified options 2013-06-29 19:32:13 +10:00
kennyj
94c72c45bb Remove passing the prompt to grouped_options_for_select as an argument, because it was deprecated. 2013-06-28 03:11:00 +09:00
Łukasz Strzałkowski
d6b1caa8f2 Check if malformed fixture exists first
Now if somebody by mistake will remove malformed files test will raise error.
2013-06-20 23:38:38 +02:00
Łukasz Strzałkowski
08998d2eec Restore mistakenly removed malformed file fixtures 2013-06-20 23:35:48 +02:00
Łukasz Strzałkowski
6241513736 Fix digestor tests 2013-06-20 17:23:16 +02:00
Łukasz Strzałkowski
c815775d01 Copy company test fixture to AV (fixes failing test) 2013-06-20 17:23:16 +02:00
Piotr Sarnacki
f12109448b Remove unneeded test fixtures in AV 2013-06-20 17:23:16 +02:00
Piotr Sarnacki
5e5bf31b4a Remove unneeded files 2013-06-20 17:23:16 +02:00
Piotr Sarnacki
eb23754ebb Move template tests from actionpack to actionview 2013-06-20 17:23:16 +02:00