bogdanvlviv
74a9a29277
Include ActiveSupport::Testing::MethodCallAssertions to ActionCable::TestCase
...
Remove all `include ActiveSupport::Testing::MethodCallAssertions`
in actioncable's tests since we can do it only in `ActionCable::TestCase`
in order to prevent code duplication.
We use the same approach for other modules of Rails.
2018-06-08 23:29:05 +03:00
utilum
78288f75e1
remove unnecessary mocking in ActionCable tests
2018-05-22 02:29:18 +02:00
utilum
d1f58e9922
assert_called_with
2018-04-26 08:02:08 +02:00
utilum
94ceda00b9
assert_called
2018-04-26 08:02:08 +02:00
Daniel Colson
a1ac18671a
Replace assert ! with assert_not
...
This autocorrects the violations after adding a custom cop in
3305c78dcd.
2018-04-19 08:11:33 -04:00
Daniel Colson
94333a4c31
Use assert_predicate and assert_not_predicate
2018-01-25 23:32:59 -05:00
Kir Shatrov
385825fb70
Use frozen string literal in actioncable/
2017-07-23 23:30:29 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Xavier Noria
411ccbdab2
remove redundant curlies from hash arguments
2016-08-06 19:44:11 +02:00
Xavier Noria
f8477f13bf
applies new string literal convention in actioncable/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:15:15 +02:00
Matthew Draper
bbba0649f5
Merge pull request #23992 from matthewd/em-option
...
Support faye-websocket + EventMachine as an option
2016-03-04 05:31:48 +10:30
Matthew Draper
a373be9da4
Support faye-websocket + EventMachine as an option
2016-03-02 12:17:15 +10:30
Daniel Rhodes
f51cb7eef5
Added welcome message type and fix test hacks
2016-03-01 01:38:35 +01:00
Jon Moss
a536cc8f1e
Only hijack Rack socket when first needed
...
Fixes #23471
2016-02-24 21:48:59 -05:00
Pratik Naik
426676e8d0
Confirm connection monitor subscription on open
2016-02-23 09:37:49 -06:00
Matthew Draper
74497eabd5
Revert "Revert "Eliminate the EventMachine dependency""
2016-01-30 03:46:37 +10:30
David Heinemeier Hansson
9ea7aa84d1
Revert "Eliminate the EventMachine dependency"
2016-01-27 14:33:15 +01:00
Matthew Draper
322dca293b
Import the relevant portions of faye-websocket
...
(as adapted to use concurrent-ruby / nio4r instead of eventmachine)
2016-01-24 22:52:40 +10:30
Matthew Draper
68a9060d02
Using a hacked faye-websocket, drop EventMachine
2016-01-24 22:51:06 +10:30
David Heinemeier Hansson
01c320001b
Revert "Merge pull request #22977 from rails/revert-22934-master"
...
This reverts commit d0393fccff3b7ccadfc1
2016-01-16 15:42:20 +01:00
David Heinemeier Hansson
36fe301564
Revert "Move async execution from celluloid to concurrent-ruby"
2016-01-08 20:09:25 +01:00
Mike Perham
2bb65e64e6
Remove celluloid references
2016-01-05 15:10:11 -08:00
David Heinemeier Hansson
bf40bddfce
Get ready to merge into Rails
2015-12-14 15:48:54 +01:00
