Commit Graph

15 Commits

Author SHA1 Message Date
Koichi ITO 412156f00f Remove encoding utf-8 magic comment 2017-07-15 19:29:45 +09:00
Kir Shatrov 72950568dd Use frozen-string-literal in ActiveSupport 2017-07-09 15:08:29 +03:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
Akira Matsuda 3fe6a5d510 Privatize unneededly protected methods in Active Support tests 2016-12-24 00:22:29 +09:00
Xavier Noria bb1ecdcc67 fixes remaining RuboCop issues [Vipul A M, Xavier Noria] 2016-09-01 23:41:49 +02:00
Rafael Mendonça França 55f9b8129a
Add three new rubocop rules
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces

Fix all violations in the repository.
2016-08-16 04:30:11 -03:00
Xavier Noria a731125f12 applies new string literal convention in activesupport/test
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:10:53 +02:00
Xavier Noria cfc91c31aa systematic revision of =~ usage in AS
Where appropriate prefer the more concise Regexp#match?, String#include?,
String#start_with?, and String#end_with?
2016-07-22 23:13:49 +02:00
Vít Ondruch c245ca30f2 Skip the test if test data download fails. 2016-07-04 14:12:49 +02:00
Vít Ondruch 7d7c2d13ba DRY Downloader. 2016-07-04 13:11:44 +02:00
Jeremy Daer c280282ec0
Travis: cache unicode data downloads and beanstalkd build 2016-04-19 00:26:17 -07:00
Akira Matsuda 8f35fcec56 Put test-case dependent helper Class inside the test case
This fixes ⚠️ previous definition of download was here
2016-01-24 23:37:26 +09:00
Akira Matsuda bd2178f115 ⚠️ mismatched indentations at 'end' with 'unless' 2016-01-24 23:37:26 +09:00
Akira Matsuda 75b199753c Test files has to be named *_test.rb 2016-01-24 23:37:26 +09:00