Jeremy Kemper
71234daef1
r4487@asus: jeremy | 2006-04-29 12:21:39 -0700
...
Check whether @flash is defined? for warnings-safety.
r4488@asus: jeremy | 2006-04-29 12:23:15 -0700
Check whether @flash is defined? for warnings-safety. Obviates nil? check.
r4489@asus: jeremy | 2006-04-29 12:45:18 -0700
Check whether @session is defined? for warnings-safety.
r4490@asus: jeremy | 2006-04-29 12:50:41 -0700
Check whether @rendering_runtime is defined? for warnings-safety.
r4491@asus: jeremy | 2006-04-29 12:55:01 -0700
Check whether @_cycles is defined? for warnings-safety.
r4492@asus: jeremy | 2006-04-29 12:59:19 -0700
Check whether instance variables are defined? for warnings-safety.
r4493@asus: jeremy | 2006-04-29 13:14:09 -0700
Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
r4494@asus: jeremy | 2006-04-29 13:31:34 -0700
Check whether @auto_index defined? for warnings-safety.
r4495@asus: jeremy | 2006-04-29 13:32:24 -0700
Wrap content_columns redefinitions with silence_warnings.
r4496@asus: jeremy | 2006-04-29 13:35:28 -0700
Wrap more redefinitions with silence_warnings.
r4829@asus: jeremy | 2006-07-08 10:59:20 -0700
abstract unit, fix warnings
r4830@asus: jeremy | 2006-07-08 11:06:12 -0700
Use parens to silence warning.
r4831@asus: jeremy | 2006-07-08 11:06:48 -0700
Use parens to silence warning.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 18:14:49 +00:00
Marcel Molina
9f92dd3984
Replace alias method chaining with Module#alias_method_chain. [Marcel Molina Jr.]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4312 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-29 20:20:22 +00:00
David Heinemeier Hansson
050c3964d8
Stopped the massive bleeding of concerns into ActionController::Base. Base no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 05:51:02 +00:00
Sam Stephenson
06dd1f2ca3
Add render :update for inline RJS
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-20 22:04:07 +00:00
David Heinemeier Hansson
ba91f9feaf
Dont log size of request, doesnt work well with procs, not that interesting
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 20:03:31 +00:00
David Heinemeier Hansson
d87618d20d
Log request method and response size / status code
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 08:43:17 +00:00
David Heinemeier Hansson
f86276b305
Fix fragment benchmark calls and limit timings to 5 decimals
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
291c667d66
Only do benchmarking if log level matches and log caching
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 17:07:08 +00:00
David Heinemeier Hansson
5e8e8d6564
Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-06 16:48:18 +00:00
Jamis Buck
211617191e
Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-23 09:43:36 +00:00
David Heinemeier Hansson
4f40b2d8fb
Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
607ce7f0a0
Move URI to the end for greater overview
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1716 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:14:19 +00:00
David Heinemeier Hansson
977b4be208
Changed logging of SQL statements to use the DEBUG level instead of INFO. Added logging of the request URI in the benchmark statement (makes it easy to grep for slow actions). Changed the default logging level in config/environment.rb to INFO for production (so SQL statements won't be logged)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 17:23:41 +00:00
Jamis Buck
f8542a64b3
Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:00:46 +00:00
David Heinemeier Hansson
da0c4c5c96
Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
aa236c4425
Fixed that rendering a template would require a connection to the database #1146
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1222 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 09:57:15 +00:00
David Heinemeier Hansson
420b830b00
Fixed that rendering a template would require a connection to the database #1146
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 09:54:10 +00:00
David Heinemeier Hansson
91834e0c3f
Fixed that benchmarking times for rendering included db runtimes #987 [skaes@web.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:31:58 +00:00
David Heinemeier Hansson
db045dbbf6
Initial
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2004-11-24 01:04:44 +00:00