7 commits

Author	SHA1	Message	Date
Kir Shatrov	831be98f9a	Use frozen-string-literal in ActiveRecord	2017-07-19 22:27:07 +03:00
Matthew Draper	87b3e226d6	Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" ... This reverts commit 3420a14590, reversing changes made to afb66a5a59.	2017-07-02 02:15:17 +09:30
Kir Shatrov	cfade1ec7e	Enforce frozen string in Rubocop	2017-07-01 02:11:03 +03:00
Jon Leighton	0a12a5f816	Deprecate eager-evaluated scopes. ... Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions	2012-03-21 22:18:18 +00:00
Jon Leighton	1a474cc8e4	Deprecate set_primary_key in favour of self.primary_key=	2011-11-29 20:13:37 +00:00
Jon Leighton	735d985b01	The join_nodes must be passed to the JoinDependency initializer and therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556.	2011-08-29 15:05:47 +01:00
Jim Remsik and Tim Pope	1e6c50e21b	Ensure has_many :through works with changed primary keys [#736 state:resolved] ... Signed-off-by: Pratik Naik <pratiknaik@gmail.com>	2009-03-09 13:43:28 +00:00