1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

14 commits

Author SHA1 Message Date
Javan Makhmali
3e4ecbe8e6 Store reference to Subscriptions instance for convenience 2016-03-03 21:44:11 -05:00
Javan Makhmali
96e6de9552 Defer starting connection monitor until a connection is opened 2016-03-03 20:23:20 -05:00
Javan Makhmali
82a1bf268d Establish WebSocket connection when first subscription is created. Fixes #24026
* More intention revealing than connecting on the first call to Connection#send
* Fixes that calls to Connection#send would attempt to open a connection when the WebSocket's state is CONNECTING
2016-03-03 17:59:12 -05:00
Daniel Rhodes
78b0ac3259 ConnectionMonitor is once again notified of disconnect 2016-03-03 15:00:11 +01:00
Daniel Rhodes
53e163dc3f Make ping into a message type
This change makes ping into a message type, which
makes the whole protocol a lot more consistent.

Also fixes hacks on the client side to make this all
work.
2016-03-01 02:48:15 +01:00
Daniel Rhodes
f51cb7eef5 Added welcome message type and fix test hacks 2016-03-01 01:38:35 +01:00
Jon Moss
1afd414488 Only open Action Cable connection if data is being sent 2016-02-24 20:37:52 -05:00
Javan Makhmali
c889408e0d Fix isAlive condition and add more logging 2016-02-23 09:37:50 -06:00
Javan Makhmali
dde833816a ActionCable.log 2016-02-23 09:37:50 -06:00
Javan Makhmali
1a90ff9a4d Uninstall event handlers when replacing WebSocket instance
Ensures we don't get "onclose" events from a previous WebSocket that was in the "closing" state
2016-02-23 09:37:49 -06:00
Javan Makhmali
ab28276713 Connection#isAlive 2016-02-23 09:37:49 -06:00
Pratik Naik
725c913c90 Treat 'closing' state as closed.
We are seeing cases where the websockets get stuck in the 'closing' state
after a tab has been in background for a while. So lets treat those websockets
as closed.
2016-02-23 09:37:49 -06:00
Javan Makhmali
832f88bdf3 Add client-side console logging to help debug reconnect issues 2016-02-23 09:37:49 -06:00
Matthew Draper
d6f2000a67 Wrangle the asset build into something that sounds more general 2016-02-01 05:03:03 +10:30
Renamed from actioncable/app/assets/javascripts/action_cable/source/connection.coffee (Browse further)