Ryuta Kamizono
c81af6ae72
Enable Layout/EmptyLinesAroundAccessModifier cop
...
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776 ,
https://github.com/rails/rails/pull/34832#discussion_r244847195 ).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059 ).
That cop and enforced style will reduce the our code review cost.
2019-06-13 12:00:45 +09:00
Pat Allan
acea68de02
Adding frozen_string_literal pragma to Railties.
2017-08-14 19:08:09 +02:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Akira Matsuda
d1daf4c313
Privatize unneededly protected methods in Railties
2016-12-25 02:11:40 +09:00
Xavier Noria
a9dc45459a
code gardening: removes redundant selfs
...
A few have been left for aesthetic reasons, but have made a pass
and removed most of them.
Note that if the method `foo` returns an array, `foo << 1`
is a regular push, nothing to do with assignments, so
no self required.
2016-08-08 01:12:38 +02:00
Xavier Noria
80e66cc4d9
normalizes indentation and whitespace across the project
2016-08-06 20:16:27 +02:00
Xavier Noria
69ab3eb57e
applies new string literal convention in railties/lib
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:15:47 +02:00
Robin Dupret
5ad7f8ab41
Use Ruby 1.9 Hash syntax in railties
2012-10-14 18:26:58 +02:00
Xavier Noria
72cca79d36
adds missing require
2011-06-07 12:06:02 +02:00
Santiago Pastorino
ab2bde45f8
Remove require AS::Concern from places where is already in
2010-12-19 19:15:26 -02:00
Santiago Pastorino
13e5a26dbb
Fix indentation
2010-12-19 14:00:09 -02:00
Santiago Pastorino
7b875953b8
Use Concern in Rails::Railtie::Configurable
2010-12-19 14:00:09 -02:00
Piotr Sarnacki
32a5b49911
Move singleton pattern to Railtie and remove Engine::Configurable and Application::Configurable in favor of unified Railtie::Configurable
2010-09-03 22:59:05 +02:00
José Valim
b17e358e3d
Move configuration to subfolders.
2010-01-23 22:30:17 +01:00
José Valim
788fce2550
Create configurable modules and ensure that they are added only on direct children.
2010-01-23 18:41:53 +01:00
