Kir Shatrov
dfcc766163
Use frozen string literal in actionpack/
2017-07-29 14:02:40 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Ryuta Kamizono
762e3f05f3
Add Style/EmptyLines in .rubocop.yml and remove extra empty lines
2016-08-07 17:50:59 +09:00
Xavier Noria
80e66cc4d9
normalizes indentation and whitespace across the project
2016-08-06 20:16:27 +02:00
Xavier Noria
5b6eb1d58b
modernizes hash syntax in actionpack
2016-08-06 19:35:13 +02:00
Xavier Noria
35b3de8021
applies new string literal convention in actionpack/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:54:50 +02:00
Rafael Mendonça França
027d484f1d
Prefer request_id over uuid and test the alias
2015-02-20 20:47:59 -02:00
Rafael Mendonça França
bb6fe7e73a
Consistent usage of spaces in hashes across our codebase
2015-01-29 12:19:41 -02:00
Kir Shatrov
baf14ae513
Switch to kwargs in ActionController::TestCase and ActionDispatch::Integration
...
Non-kwargs requests are deprecated now.
Guides are updated as well.
`post url, nil, nil, { a: 'b' }` doesn't make sense.
`post url, params: { y: x }, session: { a: 'b' }` would be an explicit way to do the same
2015-01-29 14:44:46 +02:00
Jose and Yehuda
56cdc81c08
Remove default match without specified method
...
In the current router DSL, using the +match+ DSL
method will match all verbs for the path to the
specified endpoint.
In the vast majority of cases, people are
currently using +match+ when they actually mean
+get+. This introduces security implications.
This commit disallows calling +match+ without
an HTTP verb constraint by default. To explicitly
match all verbs, this commit also adds a
:via => :all option to +match+.
Closes #5964
2012-04-24 22:52:26 -05:00
Arun Agrawal
a3c1dc223b
removed warning "warning: ambiguous first argument; put parentheses or even spaces"
2011-12-21 21:22:39 +05:30
Arun Agrawal
0f510e970f
Using uuid which is supported in 1.9
...
Orignal commit #ada78066fdbccffb1da092a2470211fa252b3c99
2011-12-21 17:55:57 +05:30
Arun Agrawal
50dfd58fdb
Warnings removed from RequestIdTest
2011-10-22 16:30:48 +05:30
José Valim
f1fecd9b4e
Make tests run on 1.8.x, add integration setup.
2011-10-19 22:09:36 +02:00
David Heinemeier Hansson
ada78066fd
Blah, SecureRandom#uuid is not supported in 1.8.7 -- cant wait for Rails 4.0 to drop compatibility with 1.8.x
2011-10-19 14:45:42 -05:00
David Heinemeier Hansson
afde6fdd5e
Added X-Request-Id tracking and TaggedLogging to easily log that and other production concerns
2011-10-19 12:59:33 -05:00
