Kir Shatrov
dfcc766163
Use frozen string literal in actionpack/
2017-07-29 14:02:40 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Rafael Mendonça França
fe1f4b2ad5
Add more rubocop rules about whitespaces
2016-10-29 01:17:49 -02:00
Xavier Noria
35b3de8021
applies new string literal convention in actionpack/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:54:50 +02:00
Aaron Patterson
703275ba70
use the mapper to build the routing table
...
We should build the routes using the user facing API which is `Mapper`.
This frees up the library internals to change as we see fit. IOW we
shouldn't be testing internals.
2015-08-15 14:32:04 -07:00
Aaron Patterson
a293812bff
only keep one hash of named routes
...
The outer router object already keeps a hash of named routes, so we
should just use that.
2015-08-14 18:06:48 -07:00
Aaron Patterson
4bdd92d9fd
rm add_route2
...
refactor the tests with a backwards compatible method call so we can rm
add_route2 from the journey router
2015-08-14 16:25:03 -07:00
Aaron Patterson
947ebe9a6d
remove Strexp
...
This was a useless object. We can just directly construct a
Path::Pattern object without a Strexp object.
2015-08-13 15:42:46 -07:00
Aaron Patterson
4868692687
pass anchor directly to Pattern
...
the caller already has it, there is no reason to pack it in to an object
and just throw that object away.
2015-08-13 15:16:25 -07:00
Aaron Patterson
8037d7eacd
extract required_defaults from the conditions hash before constructing the route
...
this way we can remove the strange "respond_to?" conditional in the
`matches?` loop
2015-06-08 17:18:32 -07:00
Rafael Mendonça França
d4cfd54308
Prefer assert_not over refute
2015-05-18 19:33:25 -03:00
Valentine Valyaeff
bad30ed46c
ActionDispatch::Journey::Routes#empty? test cases
2015-05-19 01:21:20 +03:00
Aaron Patterson
12f2fc56aa
Merge pull request #15806 from tgxworld/partition_routes_during_setup
...
Partition routes during setup.
2015-03-02 15:02:14 -08:00
Zoltan Kiss
f5b192837a
Remove unneeded comment. [ci skip]
2015-03-02 11:03:33 -06:00
Guo Xiang Tan
89edfbd3a4
Partition routes during setup.
...
Partitioning of all the routes is currently being done during the
first request. Since there is no need to clear the cache for
`partitioned_routes` when adding a new route. We can move the
partitioning of the routes during setup time.
2015-02-26 12:18:20 +08:00
Aaron Patterson
bb207ea7b6
Path::Pattern is instantiated internally, so make the contructor require a strexp object
2014-05-29 15:44:54 -07:00
Aaron Patterson
15ffbedf3b
add an alternate constructor to Strexp that takes a string
2014-05-29 15:23:30 -07:00
Rafael Mendonça França
dc8091b88f
Use ActiveSupport::TestCase in the journey tests
2012-12-31 14:40:43 -03:00
Rafael Mendonça França
5294ad82c6
Alias refute methods to assert_not and perfer assert_not on tests
2012-12-31 13:58:52 -03:00
Andrew White
56fee39c39
Integrate Journey into Action Dispatch
...
Move the Journey code underneath the ActionDispatch namespace so
that we don't pollute the global namespace with names that may
be used for models.
Fixes rails/journey#49 .
2012-12-19 22:13:08 +00:00
