Koichi ITO
ac717d65a3
[Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment
2017-07-11 13:12:32 +09:00
Kir Shatrov
72950568dd
Use frozen-string-literal in ActiveSupport
2017-07-09 15:08:29 +03:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590
, reversing
changes made to afb66a5a59
.
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
thedarkone
9f84e60ac9
Make DescendantsTracker thread safe and optimize the #descendants method.
2012-10-18 12:08:01 -07:00
Rolf Timmermans
d89a7967b5
Revert "Revert "It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free.""
...
This reverts commit 9f5b1e1ed0
.
Tests have been refactored so they pass in isolation.
2011-03-13 17:08:33 +01:00
José Valim
9f5b1e1ed0
Revert "It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free."
...
This reverts commit 46f6a2e388
.
Caused failures on CI. rake test:isolated on activesupport directory show them.
2011-03-13 08:35:50 +01:00
Rolf Timmermans
46f6a2e388
It should be possible to use ActiveSupport::DescendantTracker without getting ActiveSupport::Dependencies for free.
2011-03-13 01:33:10 +08:00
Santiago Pastorino
21c4b0942f
Don't shadow outer local variables
2010-07-22 15:48:52 -03:00
José Valim
a5dda97602
Define a convention for descendants and subclasses.
...
The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children.
By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts.
2010-07-05 13:01:27 +02:00
José Valim
d430db9fd4
Remove descendants warning while executing tests.
2010-06-19 17:16:11 +02:00
José Valim
8db8c6f4ce
Add ActiveSupport::DescendantsTracker.
2010-06-19 16:44:35 +02:00