Commit Graph

17 Commits

Author SHA1 Message Date
John Bampton de3b207aa6 chore: fix grammar and spelling 2021-04-15 16:57:01 +10:00
Akira Matsuda 62d089a4ad Suppress Ruby warning: ⚠️ non-nil $, will be deprecated 2019-07-29 12:55:28 +09:00
Daniel Colson 94333a4c31 Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
Kir Shatrov 424117281e Use frozen string literal in actionview/ 2017-07-24 11:53:43 +03:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
kenta-s b14ac2f7da Improve insufficient test for `safe_join` 2017-01-30 19:44:17 +09:00
yui-knk f7950b480c Keep the value of `$,` and restore it
As unit tests, we do not know the value of `$,` when this
test case started. It' better to keep the value when the
test case fnished.
2017-01-25 09:35:39 +09:00
Rafael França a4dbbde4c9 Merge pull request #27693 from kenta-s/improve-to_sentence-method
Fix unexpected behavior of `to_sentence` with $,
2017-01-18 01:43:16 -05:00
kenta-s 8040f527c3 Fix unexpected behavior of with $, 2017-01-15 21:10:05 +09:00
kenta-s 3156095590 Add test for safe_join 2017-01-15 13:04:52 +09:00
Rafael Mendonça França fe1f4b2ad5
Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
Xavier Noria 4b6c68dfb8 applies new string literal convention in actionview/test
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:50:17 +02:00
Neil Matatall 9baedc8a96
mimic ActiveSupport's Array#to_sentence in an html_safe-aware way 2016-03-15 09:22:11 -10:00
Vipul A M b387d9a14a html_safe is not supposed to be public API for AV. This change removes usage of html_safe in favour of raw() in AV helpers.
Also changed usage of html_safe to make use of raw() instead so that the intended behaviour is verified with raw()
2016-01-20 12:38:59 +05:30
Paul Grayson bcab3f20da In tag helper, honor html_safe on array parameters; also make safe_join more similar to Array.join by first calling flatten. 2014-06-12 15:30:40 -07:00
Piotr Sarnacki eb23754ebb Move template tests from actionpack to actionview 2013-06-20 17:23:16 +02:00