c81af6ae72
Enable `Layout/EmptyLinesAroundAccessModifier` cop
...
We sometimes say "✂️ newline after `private`" in a code review (e.g.
https://github.com/rails/rails/pull/18546#discussion_r23188776 ,
https://github.com/rails/rails/pull/34832#discussion_r244847195 ).
Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style
`EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059 ).
That cop and enforced style will reduce the our code review cost.
2019-06-13 12:00:45 +09:00
3b7a4d3d75
Upgrade Rubocop to 0.61.1 and fix offenses
2018-12-10 19:22:56 -02:00
831be98f9a
Use frozen-string-literal in ActiveRecord
2017-07-19 22:27:07 +03:00
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590afb66a5a59
2017-07-02 02:15:17 +09:30
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
8e1b28ad7f
Fix typo s/with/without/
...
Follow up to #27109 .
2016-11-20 05:47:30 +09:00
7b6b52d6bc
Fix tests for prepared_statements: false and queries hitting `#select_all`
...
- The query needs to be executed for hitting `select_all` so made sure
that query gets executed.
- Also instead of changing instance variable, just add new
configuration for prepared_statements: false and use it for this
test.
- This way we don't have to touch the internals of AR code and still
disable prepared statements config for this test.
2016-11-19 21:52:52 +05:30
81e16dad6c
Erubis is not actually used in AR
2016-11-06 03:42:16 +09:00
9617db2078
applies new string literal convention in activerecord/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 18:26:53 +02:00
e510c2c642
Add require 'pathname' as it has not already been required in some circumstances
2011-06-17 14:55:34 +01:00
86bbba1ffb
Add support for using an ARCONFIG environment variable to specify the location of the config.yml file for running the tests
2011-06-12 19:08:16 +01:00
3b7d100b51
Fix typo
2011-06-05 11:28:17 +01:00
253bb6b926
Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
2011-06-04 23:47:03 +01:00
Ryuta Kamizono