Commit Graph

18 Commits

Author SHA1 Message Date
Robin Dupret f1e4d3d8dd Update bug report templates
Given that Bundler 1.10 was released back in 2015, we can assume
that people are at least on this version or a higher one so there
is no need to ask people to upgrade.

Also, given that Rails 5.0 supports Ruby 2.2+ and given that this
version come with Minitest 5.4.3 bundled, we don't need to ensure
backward compatibility with Minitest 4.
2018-10-28 18:12:48 +01:00
Xavier Noria f589e20b0a use "minitest" consistently
The name of the minitest library is spelled that way: regular font, and
lowercase. Lowercase is used even at the beginning of sentences, see

    http://docs.seattlerb.org/minitest/

I double-checked this with @zenspider too (thanks!).
2018-09-11 23:57:25 +02:00
bogdanvlviv 690ce38cfe Update bug report templates
Prepare bug report templates for Rails 6.0 development

Add missing `require "active_support"` in `guides/bug_report_templates/generic_gem.rb`
2018-02-17 22:53:14 -08:00
SHIBATA Hiroshi fd6522a4b4 Revert "Specify bundler version in template files"
This reverts commit b106242f52.
2017-12-22 23:07:14 +09:00
yuuji.yaginuma 2a26ff80e8 Use released arel
Related to 2e0fe5928f
2017-11-15 10:00:43 +09:00
yuuji.yaginuma b106242f52 Specify bundler version in template files
We have already specified to install `bundler` 1.15.4 in `.travis.yml`.
https://github.com/rails/rails/blob/master/.travis.yml#L31..L32

However, `bundler` 1.16.0 may be used in the test.
https://travis-ci.org/rails/rails/jobs/296582467#L2208

The test failed due to this influence.
In order to avoid this, specifying `bundler` version in bug report
templates.
2017-11-03 22:25:47 +09:00
bogdanvlviv 615415ba81
Set proper migration' version in bug report templates 2017-10-18 16:28:12 +03:00
Ryuta Kamizono a151d8ad89 Add newlines before/after the `git_source` in bug report templates
[ci skip]
2017-09-27 17:55:43 +09:00
bogdanvlviv 3e0a858aed
Change :github git source for bug report templates
:github source uses `git://` url by default, `https://` is recommended.
See http://bundler.io/v1.15/guides/git.html#security

We do the same in our `Gemfile` and templates.
2017-09-27 00:02:11 +03:00
Koichi ITO 1f37d846a9 Use frozen string literal in guides/ 2017-08-13 22:04:09 +09:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
yuuji.yaginuma 2dafc4be22 Do not use private API in bug report templates
`ActiveRecord::Migrator` is private API.
bb9d6eb094/activerecord/lib/active_record/migration.rb (L977)

Therefore, it is not good to use it in bug report templates.
Instead, should use the public API `ActiveRecord::Migration#migrate`.
2017-06-22 08:08:45 +09:00
Matthew Draper 6c08d480f1 Start Rails 5.2 development 2017-03-22 10:11:39 +10:30
Rafael Mendonça França ea9566f6cd
Use released arel 2017-02-21 11:46:42 -05:00
Rafael Mendonça França e646bad5b7
Remove deprecated support to passing a column to #quote 2016-12-29 17:53:03 -05:00
Rafael Mendonça França fe1f4b2ad5
Add more rubocop rules about whitespaces 2016-10-29 01:17:49 -02:00
Girish Sonawane 084211a7da bug report template for migrations (#26488)
* added bug report template for migrations
2016-09-15 07:28:12 -04:00