1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

22 commits

Author SHA1 Message Date
Alan Skorkin
d92ade339c Log digest as :debug instead of :info 2014-07-15 14:18:32 +10:00
David Heinemeier Hansson
637bb726ca Digestor should just rely on the finder to know about the format and the variant -- trying to pass it back in makes a mess of things (oh, and doesnt work) 2014-03-21 19:38:59 +01:00
David Heinemeier Hansson
4bca34750d Log the full path, including variant, that the digestor is trying to find 2014-03-21 19:37:34 +01:00
David Heinemeier Hansson
06b4f01fca Fix for digestor to consider variants for partials -- this still needs more testing!! 2014-03-21 19:37:29 +01:00
Arun Agrawal
886fcb0f77 Warning removed (...) interpreted as grouped expression 2014-03-20 21:01:00 +05:30
Jeremy Kemper
0da775846a Clarify AV::Digestor.digest method signature docs and deprecation warning 2014-03-15 06:55:14 -07:00
Rafael Mendonça França
d17b87919f Fix the resolver cache and stop mutating the lookup_context
Before we had a bug in the resolver cache so the disable_cache were not
working when passing options to find
2014-03-14 17:32:32 -03:00
Łukasz Strzałkowski
2c2326e6ea Introduce #with_formats_and_variants to prevent problems with mutating finder object 2014-03-14 13:41:06 +01:00
Łukasz Strzałkowski
3b9daf0ff9 Rename _setup_options to _options_for_digest 2014-03-14 13:18:20 +01:00
Łukasz Strzałkowski
4725d58896 Disable LookupContext's cache when looking for template 2014-03-14 13:18:20 +01:00
Łukasz Strzałkowski
48a6baea5e Don't pass hash as keys to #find method 2014-03-14 13:18:20 +01:00
Łukasz Strzałkowski
0ca6836a5a Don't create addition vars, use options[] directly 2014-03-13 17:53:23 +01:00
Piotr Chmolowski
025c691536 Ensure LookupContext in Digestor selects correct variant
Related to: #14242 #14243 14293

Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.

I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
2014-03-09 08:47:17 +01:00
Piotr Chmolowski
1858cc6070 Variants in ActionView::Digestor
Take variants into account when calculating template digests in
ActionView::Digest.

Digestor#digest now takes a hash as an argument to support variants and
allow more flexibility in the future. Old-style arguments have been
deprecated.

Fixes #14242
2014-03-04 15:02:58 +01:00
Brad Murray
0cdce7f910 add a new local variable to track if digests are being stored, to ensure the cleanup works correctly 2013-10-17 09:00:37 +13:00
Brad Murray
af1dc7f08a update digestor code based on review 2013-10-15 21:08:47 +13:00
Brad Murray
2b3a349123 Ensure ActionView::Digest.cache is correctly cleaned up when
ActionView::Resolver.caching = false.
2013-10-15 11:17:11 +13:00
Daniel Schierbeck
77e79ecd92 Bust the template digest cache key when details are changed
Since the lookup details will influence which template is resolved, they
need to be included in the cache key -- otherwise two different
templates may erroneously share the same digest value.
2013-09-19 10:25:14 +02:00
Josh Lauer
7e74a01f84 Only cache template digests if config.cache_template_loading
since ActionView::Resolver.caching is set to the same value as config.cache_template_loading
only cache template digests if config.cache_template_loading is not falsy
fixes issues #10752 and #10791
2013-08-06 14:06:42 -04:00
thedarkone
650810fc6c AV::Digestor thread safety fixes.
This fixes potential thread safety issues introduced in 09f6fe1. The problem
with the original code was that the "recursion-stopping" `nil` values could
be seen by other threads.
2013-07-30 15:21:32 +02:00
Rafael Mendonça França
09f6fe1cd4 Fix "Stack Level Too Deep" error when rendering recursive partials
When rendering recursive partial Action View is trying to generate the
view digest infinitly causing a stack level error.

Fixes #11340
2013-07-07 13:44:16 -03:00
Piotr Sarnacki
0d6e8edc2a Move actionpack/lib/action_view* into actionview/lib 2013-06-20 17:23:15 +02:00
Renamed from actionpack/lib/action_view/digestor.rb (Browse further)