5 commits

Author	SHA1	Message	Date
Xavier Noria	d22e522179	modernizes hash syntax in activerecord	2016-08-06 19:37:57 +02:00
Jon Leighton	0a12a5f816	Deprecate eager-evaluated scopes. ... Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions	2012-03-21 22:18:18 +00:00
Jon Leighton	6f84c73dc4	Un-deprecate using 'default_scope' as a macro, but if you are calling the macro multiple times that will give deprecation warnings, and in 3.2 we will simply overwrite the default scope when you call the macro multiple times.	2011-04-18 23:15:38 +01:00
Jon Leighton	5740d4ec0c	Deprecated support for passing hashes and relations to default_scope, in favour of defining a 'default_scope' class method in the model. See the CHANGELOG for more details.	2011-04-12 19:46:04 -07:00
José Valim	67582f08bf	Push a failing test for issues [#4994] and [#5003].	2010-06-29 19:50:09 +02:00