Jan Habermann
eeb9fda8e2
[ActionCable] remove not needed protected call and newlines
2015-12-25 14:08:50 +01:00
eileencodes
7eae0bb88e
Change alpha to beta1 to prep for release of Rails 5
...
🎉 🍻
2015-12-18 12:14:09 -05:00
Akshay Vishnoi
ebad5c72d3
[ci skip] Fix grammar
2015-12-18 16:30:18 +05:30
Akshay Vishnoi
2728377d0f
[ci skip] Fix typo
2015-12-18 12:12:52 +05:30
Guillermo Iguaran
80e00ac84a
Merge pull request #22639 from arunagw/aa-remove-few-warnings-actioncable
...
Remove warnings from actioncable test
2015-12-17 17:47:39 -05:00
eileencodes
19e7f65dd1
Don't log Action Cable to STDOUT in development
...
Logging Action Cable to STDOUT caused the development log to see double
messages like this:
```
Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500
Started GET "/" for ::1 at 2015-12-17 15:21:34 -0500
Processing by Rails::WelcomeController#index as HTML
Processing by Rails::WelcomeController#index as HTML
Rendered /welcome/index.html.erb (0.0ms)
Rendered /welcome/index.html.erb (0.0ms)
Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms)
Completed 200 OK in 3ms (Views: 1.3ms | ActiveRecord: 0.0ms)
```
Now that Action Cable is part of Rails it doesn't need it's own logger
and will log to STDOUT via the local dev server here:
https://github.com/rails/rails/blob/master/railties/lib/rails/commands/server.rb
2015-12-17 15:30:40 -05:00
Gaurav Sharma
c9b750f951
traditional make sense with <tt>ActiveSupport::TaggedLogging</tt>
2015-12-18 00:30:36 +05:30
Arun Agrawal
e1459c7c86
Remove warnings from actioncable
...
Warnings coming from code and test are removed
2015-12-17 16:42:34 +01:00
David Heinemeier Hansson
59db9ebc0c
Cargo cult fix to make Celluloid behave
2015-12-16 20:36:11 +01:00
David Heinemeier Hansson
910572fffe
Another stab at only mounting redis if the config is there
2015-12-16 18:17:12 +01:00
David Heinemeier Hansson
7eb12796ca
Assume that the cable server is running in-process by default, offer option to change that in config/environments/production.rb
2015-12-16 18:17:12 +01:00
David Heinemeier Hansson
51ad57989d
Doh, should have read ff370ee617
...
Indeed we need this to be an engine for the internal assets to work
2015-12-16 15:52:46 +01:00
David Heinemeier Hansson
6bfd191c0f
Only initialize redis if the config file is there
2015-12-16 15:42:35 +01:00
David Heinemeier Hansson
deac988756
Include changes made to the engine
2015-12-16 15:31:25 +01:00
David Heinemeier Hansson
346a7528ef
We are using railtie, not engine
2015-12-16 15:28:50 +01:00
Rafael Mendonça França
649b9d9321
Move the require to the right place
2015-12-15 16:05:42 -02:00
Rafael Mendonça França
23faa711c9
Remove the default logger
...
It should be configured through the railtie
2015-12-15 16:02:47 -02:00
Rafael Mendonça França
96455349ff
Configure the Action Cable's redis in the engine
...
This will decouple Action Cable from Rails.
2015-12-15 15:59:00 -02:00
Rafael Mendonça França
ff370ee617
Action Cable need to be a engine
...
Otherwise assets will not work
2015-12-15 15:21:36 -02:00
David Heinemeier Hansson
a8db0328a5
Switch from engine to railtie
2015-12-15 13:10:27 +01:00
Rafael Mendonça França
3d4a423cdc
Hook in ActionView::Base, not in ApplicationController
...
The application can have more than one ApplicationController and we
want Action Cable helpers in all controllers and their views so we
should hook in the same place that others helpers.
2015-12-14 15:54:08 -02:00
Rafael Mendonça França
f8058a6aeb
Require the top level file in the engine
2015-12-14 15:53:43 -02:00
David Heinemeier Hansson
760de782f7
Initial stab at adding Action Cable to rails/master
2015-12-14 16:38:37 +01:00
David Heinemeier Hansson
bf40bddfce
Get ready to merge into Rails
2015-12-14 15:48:54 +01:00
