1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Commit graph

12 commits

Author SHA1 Message Date
Rafael Mendonça França
55f9b8129a
Add three new rubocop rules
Style/SpaceBeforeBlockBraces
Style/SpaceInsideBlockBraces
Style/SpaceInsideHashLiteralBraces

Fix all violations in the repository.
2016-08-16 04:30:11 -03:00
Xavier Noria
1607ee299d modernizes hash syntax in guides 2016-08-06 19:39:28 +02:00
Xavier Noria
6b3719b757 applies new string literal convention in guides
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:21:59 +02:00
Seiei Miyagi
d3959c55e3 concatenate @lang if @lang is presence to avoid useless slash 2015-10-05 23:53:05 +09:00
Seiei Miyagi
b2e490ef54 Add ability to translate rails guides documents.yaml
Some translations of rails guides has their own documents.yaml, for example

Japanese:
https://github.com/yasslab/railsguides.jp/blob/japanese/guides/source/documents.yaml

Traditional Chinese:
https://github.com/docrails-tw/guides/blob/master/rails_guides/helpers.rb#L21,L27
https://github.com/docrails-tw/guides/blob/master/source/documents_zh-TW.yaml

The [Translating Rails Guides](https://github.com/rails/docrails/wiki/translating-rails-guides) says

> Copy the contents of guides/source into your own language directory and translate them.

So that sounds ok to copy guides/source/documents.yaml into language
specific directly and translating them like other markdown files.
2015-10-05 23:53:04 +09:00
Nate Berkopec
220528548b Guides: output valid HTML5
[ci skip]
2014-05-05 17:42:04 -04:00
Yves Senn
67d4dc2bdb rails_guides/helpers.rb requires YAML to run.
Resolve the following error when running `bundle exec rake guides:generate:html`:

```
/Users/senny/.rbenv/versions/2.0.0-p353/bin/ruby rails_guides.rb
Generating 2_2_release_notes.md as 2_2_release_notes.html
/Users/senny/Projects/rails/guides/rails_guides/helpers.rb:17:in `documents_by_section': uninitialized constant RailsGuides::Helpers::YAML (ActionView::Template::Error)
	from /Users/senny/Projects/rails/guides/rails_guides/helpers.rb:32:in `docs_for_menu'
	from /Users/senny/Projects/rails/guides/source/layout.html.erb:56:in `block in ___sers_senny__rojects_rails_guides_source_layout_html_erb___3094858039481335962_70118647133480'
	from /Users/senny/Projects/rails/guides/source/layout.html.erb:54:in `each'
	from /Users/senny/Projects/rails/guides/source/layout.html.erb:54:in `___sers_senny__rojects_rails_guides_source_layout_html_erb___3094858039481335962_70118647133480'
	from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:143:in `block in render'
	from /Users/senny/Projects/rails/activesupport/lib/active_support/notifications.rb:161:in `instrument'
	from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:337:in `instrument'
	from /Users/senny/Projects/rails/actionview/lib/action_view/template.rb:141:in `render'
	from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:61:in `render_with_layout'
	from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:47:in `render_template'
	from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/template_renderer.rb:17:in `render'
	from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/renderer.rb:42:in `render_template'
	from /Users/senny/Projects/rails/actionview/lib/action_view/renderer/renderer.rb:23:in `render'
	from /Users/senny/Projects/rails/actionview/lib/action_view/helpers/rendering_helper.rb:24:in `render'
	from /Users/senny/Projects/rails/guides/rails_guides/markdown.rb:160:in `render_page'
	from /Users/senny/Projects/rails/guides/rails_guides/markdown.rb:25:in `render'
	from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:205:in `block in generate_guide'
	from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:195:in `open'
	from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:195:in `generate_guide'
	from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:144:in `block in generate_guides'
	from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:142:in `each'
	from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:142:in `generate_guides'
	from /Users/senny/Projects/rails/guides/rails_guides/generator.rb:97:in `generate'
	from rails_guides.rb:63:in `<main>'
rake aborted!
Command failed with status (1): [/Users/senny/.rbenv/versions/2.0.0-p353/bi...]
/Users/senny/Projects/rails/guides/Rakefile:11:in `block (3 levels) in <top (required)>'
Tasks: TOP => guides:generate:html
(See full trace by running task with --trace)
```
2014-02-03 12:01:32 +01:00
Karunakar (Ruby)
4f9ae6cfc6 used flat_map instead of map.flatten in /guides/rails_guides/helpers.rb 2013-08-04 01:13:24 +05:30
Joe Fiorini
03bcd416b0 [Guides] Navigation styling for small devices 2012-10-06 16:38:37 -04:00
Santiago Pastorino
a0613ad8a9 Revert "Use flat_map { } instead of map {}.flatten"
This reverts commit abf8de8551.
We should take a deeper look to those cases flat_map doesn't do deep
flattening.

irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten
=> [1, 3, 1, 2]
irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i}
=> [[1, 3], [1, 2]]
2012-10-05 12:07:16 -03:00
Santiago Pastorino
abf8de8551 Use flat_map { } instead of map {}.flatten 2012-10-05 11:52:20 -03:00
Xavier Noria
6d87cd028b moves the guides up to the root directory 2012-03-17 08:32:49 -07:00
Renamed from railties/guides/rails_guides/helpers.rb (Browse further)