Christian Schmidt
6cd184ff0f
Use image/jpeg instead of non-standard image/jpg
2021-03-05 13:14:11 -05:00
Eugene Kenny
e44b3419d4
Prefix keys in Active Storage service test
...
Otherwise this test fails when run concurrently.
https://buildkite.com/rails/rails/builds/71999#77923632-f943-4fa0-b478-0af38001c22b/1032-1098
https://buildkite.com/rails/rails/builds/71999#01fdec79-dc1f-4a6a-b730-ac0df134a2e7/970-1062
2020-10-07 21:47:59 +01:00
Ryuta Kamizono
892e38c78e
Enable Style/RedundantBegin cop to avoid newly adding redundant begin block
...
Currently we sometimes find a redundant begin block in code review
(e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205 ).
I'd like to enable `Style/RedundantBegin` cop to avoid that, since
rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5
(https://bugs.ruby-lang.org/issues/12906 ), so we'd probably meets with
that situation than before.
2018-12-21 06:12:42 +09:00
yuuji.yaginuma
6ca2f2acb2
metadata is not passed to service
...
Ref: 604fac6d71/activestorage/app/models/active_storage/blob.rb (L256-L264)https://travis-ci.org/rails/rails/jobs/461868394#L6624-L6626
Follow up to #34576 .
2018-12-01 09:12:55 +09:00
Yannick Schutz
7bd21e8575
Add a test with extra keys to active_storage Service#upload
2018-11-30 15:54:38 +01:00
Rafael Mendonça França
f679933daa
Change the empty block style to have space inside of the block
2018-09-25 13:19:35 -04:00
yuuji.yaginuma
1b86d90136
Enable Performance/UnfreezeString cop
...
In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`.
```ruby
# frozen_string_literal: true
require "bundler/inline"
gemfile(true) do
source "https://rubygems.org "
gem "benchmark-ips"
end
Benchmark.ips do |x|
x.report('+@') { +"" }
x.report('dup') { "".dup }
x.compare!
end
```
```
$ ruby -v benchmark.rb
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
Warming up --------------------------------------
+@ 282.289k i/100ms
dup 187.638k i/100ms
Calculating -------------------------------------
+@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s
dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s
Comparison:
+@: 6775299.3 i/s
dup: 3320400.7 i/s - 2.04x slower
```
2018-09-23 08:56:55 +09:00
Cameron Bothner
5cd2d07bdc
Translate service-specific missing object exceptions into a generic one
...
`ActiveStorage::Blob#download` and `ActiveStorage::Blob#open` raise
`ActiveStorage::FileNotFoundError` when the corresponding file is missing
from the storage service. Services translate service-specific missing
object exceptions (e.g. `Google::Cloud::NotFoundError` for the GCS service
and `Errno::ENOENT` for the disk service) into
`ActiveStorage::FileNotFoundError`.
2018-08-21 15:31:14 -04:00
George Claghorn
56b9d0fd3a
Generate a new key for each service test
...
Sidestep Google Cloud Storage's restrictive per-object rate limit.
2018-06-25 18:49:26 -04:00
George Claghorn
bf5f41d948
Support streaming downloads from Google Cloud Storage
2018-05-01 23:20:56 -04:00
George Claghorn
ccac681122
Generate root-relative paths in Active Storage disk service URL methods
...
Fixes #32129 .
2018-03-05 11:54:43 -05:00
George Claghorn
8c5a7fbefd
Purge variants with their blobs
2017-12-02 22:43:28 -05:00
George Claghorn
86938c495e
Fix streaming downloads from S3/Azure Storage
...
Closes #31073 .
2017-11-06 21:29:37 -05:00
Koichi ITO
d02844f249
Use frozen string literal in Active Storage
2017-08-12 21:43:42 +09:00
Rafael Mendonça França
9330d01ada
Add 'activestorage/' from commit '3f4a7218a4a4923a0e7ce1b2eb0d2888ce30da58'
...
git-subtree-dir: activestorage
git-subtree-mainline: 0d58e7e4783f4a7218a4
2017-07-31 15:21:22 -04:00
